test(@angular-devkit/build-angular): clean up tests from ViewEngine code

Author: alan-agius4

packages/angular_devkit/build_angular/src/browser/specs/aot_spec.ts

@@ -9,7 +9,7 @@
 import { Architect } from '@angular-devkit/architect';
 import { BrowserBuilderOutput } from '@angular-devkit/build-angular';
 import { join, logging, normalize, virtualFs } from '@angular-devkit/core';
-import { createArchitect, host, veEnabled } from '../../test-utils';
+import { createArchitect, host } from '../../test-utils';
 
 describe('Browser Builder AOT', () => {
   const targetSpec = { project: 'app', target: 'build' };
@@ -31,11 +31,7 @@ describe('Browser Builder AOT', () => {
 
     const fileName = join(normalize(output.outputPath), 'main.js');
     const content = virtualFs.fileBufferToString(await host.read(normalize(fileName)).toPromise());
-    if (!veEnabled) {
-      expect(content).toContain('AppComponent.ɵcmp');
-    } else {
-      expect(content).toMatch(/platformBrowser.*bootstrapModuleFactory.*AppModuleNgFactory/);
-    }
+    expect(content).toContain('AppComponent.ɵcmp');
 
     await run.stop();
   });

packages/angular_devkit/build_angular/src/browser/specs/errors_spec.ts

@@ -8,7 +8,7 @@
 
 import { Architect } from '@angular-devkit/architect';
 import { logging } from '@angular-devkit/core';
-import { createArchitect, host, veEnabled } from '../../test-utils';
+import { createArchitect, host } from '../../test-utils';
 
 describe('Browser Builder errors', () => {
   const targetSpec = { project: 'app', target: 'build' };
@@ -68,11 +68,7 @@ describe('Browser Builder errors', () => {
     // Wait for the builder to complete
     await run.stop();
 
-    if (!veEnabled) {
-      expect(logs.join()).toContain('selector must be a string');
-    } else {
-      expect(logs.join()).toContain('Function expressions are not supported in');
-    }
+    expect(logs.join()).toContain('selector must be a string');
   });
 
   it('shows missing export errors', async () => {

packages/angular_devkit/build_angular/src/browser/specs/i18n_spec.ts

@@ -16,7 +16,6 @@ import {
   host,
   lazyModuleFiles,
   lazyModuleFnImport,
-  veEnabled,
 } from '../../test-utils';
 
 // tslint:disable-next-line:no-big-function
@@ -68,13 +67,9 @@ describe('Browser Builder lazy modules', () => {
       addLazyLoadedModulesInTsConfig(host, lazyModuleFiles);
 
       const { files } = await browserBuild(architect, host, target, { aot: true });
-      if (!veEnabled) {
-        const data = await files['lazy-lazy-module.js'];
-        expect(data).not.toBeUndefined('Lazy module output bundle does not exist');
-        expect(data).toContain('LazyModule.ɵmod');
-      } else {
-        expect(files['lazy-lazy-module-ngfactory.js']).not.toBeUndefined();
-      }
+      const data = await files['lazy-lazy-module.js'];
+      expect(data).not.toBeUndefined('Lazy module output bundle does not exist');
+      expect(data).toContain('LazyModule.ɵmod');
     });
   });
 

packages/angular_devkit/build_angular/src/browser/specs/lazy-module_spec.ts

@@ -7,8 +7,7 @@
  */
 
 import { Architect } from '@angular-devkit/architect';
-import { logging } from '@angular-devkit/core';
-import { browserBuild, createArchitect, host, veEnabled } from '../../test-utils';
+import { browserBuild, createArchitect, host } from '../../test-utils';
 
 describe('Browser Builder no entry module', () => {
   const target = { project: 'app', target: 'build' };

packages/angular_devkit/build_angular/src/browser/specs/no-entry-module_spec.ts

@@ -15,7 +15,6 @@ import {
   lazyModuleFiles,
   lazyModuleFnImport,
   outputPath,
-  veEnabled,
 } from '../../test-utils';
 
 describe('Browser Builder rebuilds', () => {
@@ -225,12 +224,6 @@ describe('Browser Builder rebuilds', () => {
   });
 
   it('rebuilds on transitive type-only file changes', async () => {
-    if (veEnabled) {
-      // TODO: https://github.com/angular/angular-cli/issues/15056
-      pending('Only supported in Ivy.');
-
-      return;
-    }
     host.writeMultipleFiles({
       'src/interface1.ts': `
         import { Interface2 } from './interface2';
@@ -351,13 +344,11 @@ describe('Browser Builder rebuilds', () => {
     // `selector must be a string` errors on VE are part of the emit result, but on Ivy they only
     // show up in getNgSemanticDiagnostics. Since getNgSemanticDiagnostics is only called on the
     // type checker, we must disable it to get a failing fourth build with Ivy.
-    const overrides = { watch: true, aot: true, forkTypeChecker: veEnabled };
+    const overrides = { watch: true, aot: true, forkTypeChecker: false };
     const logger = new logging.Logger('');
     let logs: string[] = [];
     logger.subscribe(e => logs.push(e.message));
-    const staticAnalysisError = !veEnabled
-      ? 'selector must be a string'
-      : 'Function expressions are not supported in decorators';
+    const staticAnalysisError = 'selector must be a string';
     const syntaxError = 'Declaration or statement expected.';
     let buildNumber = 0;
 

packages/angular_devkit/build_angular/src/browser/specs/rebuild_spec.ts

@@ -7,7 +7,7 @@
  */
 import { Architect } from '@angular-devkit/architect';
 import { join, normalize, virtualFs } from '@angular-devkit/core';
-import { createArchitect, host, outputPath, veEnabled } from '../../test-utils';
+import { createArchitect, host, outputPath } from '../../test-utils';
 
 describe('Browser Builder allow svg', () => {
   const target = { project: 'app', target: 'build' };
@@ -55,11 +55,7 @@ describe('Browser Builder allow svg', () => {
         host.scopedSync().read(join(outputPath, 'main.js')),
       );
 
-      if (!veEnabled) {
-        expect(content).toContain('ɵɵnamespaceSVG');
-      } else {
-        expect(content).toContain('":svg:svg"');
-      }
+      expect(content).toContain('ɵɵnamespaceSVG');
       expect(host.scopedSync().exists(normalize('dist/app.component.svg'))).toBe(
         false,
         'should not copy app.component.svg to dist',

packages/angular_devkit/build_angular/src/browser/specs/svg_spec.ts

@@ -9,7 +9,7 @@ import { Architect } from '@angular-devkit/architect';
 import { BrowserBuilderOutput } from '@angular-devkit/build-angular';
 import { logging } from '@angular-devkit/core';
 import { debounceTime, take, tap } from 'rxjs/operators';
-import { createArchitect, host, veEnabled } from '../../test-utils';
+import { createArchitect, host } from '../../test-utils';
 
 // tslint:disable-next-line:no-big-function
 describe('Browser Builder unused files warnings', () => {
@@ -25,13 +25,6 @@ describe('Browser Builder unused files warnings', () => {
   afterEach(async () => host.restore().toPromise());
 
   it('should not show warning when all files are used', async () => {
-    if (veEnabled) {
-      // TODO: https://github.com/angular/angular-cli/issues/15056
-      pending('Only supported in Ivy.');
-
-      return;
-    }
-
     const logger = new logging.Logger('');
     const logs: string[] = [];
     logger.subscribe(e => logs.push(e.message));
@@ -45,13 +38,6 @@ describe('Browser Builder unused files warnings', () => {
   });
 
   it('should show warning when some files are unused', async () => {
-    if (veEnabled) {
-      // TODO: https://github.com/angular/angular-cli/issues/15056
-      pending('Only supported in Ivy.');
-
-      return;
-    }
-
     host.replaceInFile(
       'src/tsconfig.app.json',
       '"main.ts"',
@@ -71,13 +57,6 @@ describe('Browser Builder unused files warnings', () => {
   });
 
   it('should not show warning when excluded files are unused', async () => {
-    if (veEnabled) {
-      // TODO: https://github.com/angular/angular-cli/issues/15056
-      pending('Only supported in Ivy.');
-
-      return;
-    }
-
     const ignoredFiles = {
       'src/file.d.ts': 'export type MyType = number;',
     };
@@ -109,13 +88,6 @@ describe('Browser Builder unused files warnings', () => {
   });
 
   it('should not show warning when type files are used', async () => {
-    if (veEnabled) {
-      // TODO: https://github.com/angular/angular-cli/issues/15056
-      pending('Only supported in Ivy.');
-
-      return;
-    }
-
     host.writeMultipleFiles({
       'src/app/type.ts': 'export type MyType = number;',
     });
@@ -139,13 +111,6 @@ describe('Browser Builder unused files warnings', () => {
   });
 
   it('should not show warning when type files are used transitively', async () => {
-    if (veEnabled) {
-      // TODO: https://github.com/angular/angular-cli/issues/15056
-      pending('Only supported in Ivy.');
-
-      return;
-    }
-
     host.writeMultipleFiles({
       'src/app/type.ts':
         `import {Myinterface} from './interface'; export type MyType = Myinterface;`,
@@ -171,13 +136,6 @@ describe('Browser Builder unused files warnings', () => {
   });
 
   it('works for rebuilds', async () => {
-    if (veEnabled) {
-      // TODO: https://github.com/angular/angular-cli/issues/15056
-      pending('Only supported in Ivy.');
-
-      return;
-    }
-
     host.replaceInFile(
       'src/tsconfig.app.json',
       '"**/*.d.ts"',
@@ -242,13 +200,6 @@ describe('Browser Builder unused files warnings', () => {
   });
 
   it('should only show warning once per file', async () => {
-    if (veEnabled) {
-      // TODO: https://github.com/angular/angular-cli/issues/15056
-      pending('Only supported in Ivy.');
-
-      return;
-    }
-
     host.replaceInFile(
       'src/tsconfig.app.json',
       '"**/*.d.ts"',