Skip to content

Commit f3f618f

Browse files
alan-agius4clydin
authored andcommitted
build: update critters to 0.19.0
Update critters to the latest version. Closes #25388
1 parent 5c6e3ec commit f3f618f

File tree

7 files changed

+31
-18
lines changed

7 files changed

+31
-18
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@
130130
"buffer": "6.0.3",
131131
"chokidar": "3.5.3",
132132
"copy-webpack-plugin": "11.0.0",
133-
"critters": "0.0.18",
133+
"critters": "0.0.19",
134134
"css-loader": "6.8.1",
135135
"debug": "^4.1.1",
136136
"esbuild": "0.18.3",

packages/angular_devkit/build_angular/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"browserslist": "^4.21.5",
3131
"chokidar": "3.5.3",
3232
"copy-webpack-plugin": "11.0.0",
33-
"critters": "0.0.18",
33+
"critters": "0.0.19",
3434
"css-loader": "6.8.1",
3535
"esbuild-wasm": "0.18.3",
3636
"fast-glob": "3.2.12",

packages/angular_devkit/build_angular/src/builders/app-shell/app-shell_spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ describe('AppShell Builder', () => {
160160
expect(content).toContain('app-shell works!');
161161
expect(content).toContain('p{color:#000}');
162162
expect(content).toMatch(
163-
/<link rel="stylesheet" href="styles\.[a-z0-9]+\.css" media="print" onload="this.media=&apos;all&apos;">/,
163+
/<link rel="stylesheet" href="styles\.[a-z0-9]+\.css" media="print" onload="this.media='all'">/,
164164
);
165165
});
166166

packages/angular_devkit/build_angular/src/builders/browser-esbuild/tests/options/inline-critical_spec.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ describeBuilder(buildEsbuildBrowser, BROWSER_BUILDER_INFO, (harness) => {
3535
harness
3636
.expectFile('dist/index.html')
3737
.content.toContain(
38-
`<link rel="stylesheet" href="styles.css" media="print" onload="this.media=&apos;all&apos;">`,
38+
`<link rel="stylesheet" href="styles.css" media="print" onload="this.media='all'">`,
3939
);
4040
harness.expectFile('dist/index.html').content.toContain(`body{color:#000}`);
4141
});
@@ -53,7 +53,7 @@ describeBuilder(buildEsbuildBrowser, BROWSER_BUILDER_INFO, (harness) => {
5353
harness
5454
.expectFile('dist/index.html')
5555
.content.toContain(
56-
`<link rel="stylesheet" href="styles.css" media="print" onload="this.media=&apos;all&apos;">`,
56+
`<link rel="stylesheet" href="styles.css" media="print" onload="this.media='all'">`,
5757
);
5858
harness.expectFile('dist/index.html').content.toContain(`body{color:#000}`);
5959
});
@@ -71,7 +71,7 @@ describeBuilder(buildEsbuildBrowser, BROWSER_BUILDER_INFO, (harness) => {
7171
harness
7272
.expectFile('dist/index.html')
7373
.content.toContain(
74-
`<link rel="stylesheet" href="styles.css" media="print" onload="this.media=&apos;all&apos;">`,
74+
`<link rel="stylesheet" href="styles.css" media="print" onload="this.media='all'">`,
7575
);
7676
harness.expectFile('dist/index.html').content.toContain(`body{color:#000}`);
7777
});
@@ -130,7 +130,7 @@ describeBuilder(buildEsbuildBrowser, BROWSER_BUILDER_INFO, (harness) => {
130130
harness
131131
.expectFile('dist/index.html')
132132
.content.toContain(
133-
`<link rel="stylesheet" href="styles.css" media="print" onload="this.media=&apos;all&apos;">`,
133+
`<link rel="stylesheet" href="styles.css" media="print" onload="this.media='all'">`,
134134
);
135135
harness.expectFile('dist/index.html').content.toContain(`body{color:#000}`);
136136
});

packages/angular_devkit/build_angular/src/builders/browser/tests/options/inline-critical_spec.ts

+5-5
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {
3535
harness
3636
.expectFile('dist/index.html')
3737
.content.toContain(
38-
`<link rel="stylesheet" href="styles.css" media="print" onload="this.media=&apos;all&apos;">`,
38+
`<link rel="stylesheet" href="styles.css" media="print" onload="this.media='all'">`,
3939
);
4040
harness.expectFile('dist/index.html').content.toContain(`body{color:#000}`);
4141
});
@@ -53,7 +53,7 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {
5353
harness
5454
.expectFile('dist/index.html')
5555
.content.toContain(
56-
`<link rel="stylesheet" href="styles.css" media="print" onload="this.media=&apos;all&apos;">`,
56+
`<link rel="stylesheet" href="styles.css" media="print" onload="this.media='all'">`,
5757
);
5858
harness.expectFile('dist/index.html').content.toContain(`body{color:#000}`);
5959
});
@@ -71,7 +71,7 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {
7171
harness
7272
.expectFile('dist/index.html')
7373
.content.toContain(
74-
`<link rel="stylesheet" href="styles.css" media="print" onload="this.media=&apos;all&apos;">`,
74+
`<link rel="stylesheet" href="styles.css" media="print" onload="this.media='all'">`,
7575
);
7676
harness.expectFile('dist/index.html').content.toContain(`body{color:#000}`);
7777
});
@@ -129,7 +129,7 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {
129129
harness
130130
.expectFile('dist/index.html')
131131
.content.toContain(
132-
`<link rel="stylesheet" href="http://cdn.com/styles.css" media="print" onload="this.media=&apos;all&apos;">`,
132+
`<link rel="stylesheet" href="http://cdn.com/styles.css" media="print" onload="this.media='all'">`,
133133
);
134134
harness.expectFile('dist/index.html').content.toContain(`body{color:#000}`);
135135
});
@@ -155,7 +155,7 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {
155155
harness
156156
.expectFile('dist/index.html')
157157
.content.toContain(
158-
`<link rel="stylesheet" href="styles.css" media="print" onload="this.media=&apos;all&apos;">`,
158+
`<link rel="stylesheet" href="styles.css" media="print" onload="this.media='all'">`,
159159
);
160160
harness.expectFile('dist/index.html').content.toContain(`body{color:#000}`);
161161
});

packages/angular_devkit/build_angular/src/utils/index-file/inline-critical-css_spec.ts

+6-6
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,10 @@ describe('InlineCriticalCssProcessor', () => {
5151
});
5252

5353
expect(content).toContain(
54-
`<link href="styles.css" rel="stylesheet" media="print" onload="this.media=&apos;all&apos;">`,
54+
`<link href="styles.css" rel="stylesheet" media="print" onload="this.media='all'">`,
5555
);
5656
expect(content).toContain(
57-
`<link href="theme.css" rel="stylesheet" media="print" onload="this.media=&apos;all&apos;">`,
57+
`<link href="theme.css" rel="stylesheet" media="print" onload="this.media='all'">`,
5858
);
5959
expect(content).not.toContain('color: blue');
6060
expect(tags.stripIndents`${content}`).toContain(tags.stripIndents`
@@ -75,10 +75,10 @@ describe('InlineCriticalCssProcessor', () => {
7575
});
7676

7777
expect(content).toContain(
78-
`<link href="http://cdn.com/styles.css" rel="stylesheet" media="print" onload="this.media=&apos;all&apos;">`,
78+
`<link href="http://cdn.com/styles.css" rel="stylesheet" media="print" onload="this.media='all'">`,
7979
);
8080
expect(content).toContain(
81-
`<link href="http://cdn.com/theme.css" rel="stylesheet" media="print" onload="this.media=&apos;all&apos;">`,
81+
`<link href="http://cdn.com/theme.css" rel="stylesheet" media="print" onload="this.media='all'">`,
8282
);
8383
expect(tags.stripIndents`${content}`).toContain(tags.stripIndents`
8484
<style>
@@ -98,10 +98,10 @@ describe('InlineCriticalCssProcessor', () => {
9898
});
9999

100100
expect(content).toContain(
101-
`<link href="styles.css" rel="stylesheet" media="print" onload="this.media=&apos;all&apos;">`,
101+
`<link href="styles.css" rel="stylesheet" media="print" onload="this.media='all'">`,
102102
);
103103
expect(content).toContain(
104-
`<link href="theme.css" rel="stylesheet" media="print" onload="this.media=&apos;all&apos;">`,
104+
`<link href="theme.css" rel="stylesheet" media="print" onload="this.media='all'">`,
105105
);
106106
expect(content).toContain('<style>body{margin:0}html{color:white}</style>');
107107
});

yarn.lock

+13
Original file line numberDiff line numberDiff line change
@@ -5112,6 +5112,19 @@ critters@0.0.18:
51125112
postcss "^8.4.23"
51135113
pretty-bytes "^5.3.0"
51145114

5115+
critters@0.0.19:
5116+
version "0.0.19"
5117+
resolved "https://registry.yarnpkg.com/critters/-/critters-0.0.19.tgz#15e3a3a0ed77ae4b69c3b2fe29c8e7e87fc77d1b"
5118+
integrity sha512-Fm4ZAXsG0VzWy1U30rP4qxbaWGSsqXDgSupJW1OUJGDAs0KWC+j37v7p5a2kZ9BPJvhRzWm3be+Hc9WvQOBUOw==
5119+
dependencies:
5120+
chalk "^4.1.0"
5121+
css-select "^5.1.0"
5122+
dom-serializer "^2.0.0"
5123+
domhandler "^5.0.2"
5124+
htmlparser2 "^8.0.2"
5125+
postcss "^8.4.23"
5126+
pretty-bytes "^5.3.0"
5127+
51155128
cross-fetch@3.1.5:
51165129
version "3.1.5"
51175130
resolved "https://registry.yarnpkg.com/cross-fetch/-/cross-fetch-3.1.5.tgz#e1389f44d9e7ba767907f7af8454787952ab534f"

0 commit comments

Comments
 (0)