Skip to content

Commit dcc53d0

Browse files
manfredsteyeralexeagle
authored andcommitted
feat(@angular-devkit/build-angular): add factory methods for WebpackBuilder and LoggingFactory
1 parent 554f5d2 commit dcc53d0

File tree

1 file changed

+11
-2
lines changed
  • packages/angular_devkit/build_angular/src/browser

1 file changed

+11
-2
lines changed

packages/angular_devkit/build_angular/src/browser/index.ts

+11-2
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,20 @@ export class BrowserBuilder implements Builder<BrowserBuilderSchema> {
4343

4444
constructor(public context: BuilderContext) { }
4545

46+
protected createWebpackBuilder(context: BuilderContext): WebpackBuilder {
47+
return new WebpackBuilder(context);
48+
}
49+
50+
protected createLoggingFactory(): (verbose: boolean) => LoggingCallback {
51+
return getBrowserLoggingCb;
52+
}
53+
4654
run(builderConfig: BuilderConfiguration<BrowserBuilderSchema>): Observable<BuildEvent> {
4755
const root = this.context.workspace.root;
4856
const projectRoot = resolve(root, builderConfig.root);
4957
const host = new virtualFs.AliasHost(this.context.host as virtualFs.Host<fs.Stats>);
50-
const webpackBuilder = new WebpackBuilder({ ...this.context, host });
58+
const webpackBuilder = this.createWebpackBuilder({ ...this.context, host });
59+
const getLoggingCb = this.createLoggingFactory();
5160

5261
const options = normalizeBuilderSchema(
5362
host,
@@ -67,7 +76,7 @@ export class BrowserBuilder implements Builder<BrowserBuilderSchema> {
6776
return throwError(e);
6877
}
6978

70-
return webpackBuilder.runWebpack(webpackConfig, getBrowserLoggingCb(options.verbose));
79+
return webpackBuilder.runWebpack(webpackConfig, getLoggingCb(options.verbose));
7180
}),
7281
concatMap(buildEvent => {
7382
if (buildEvent.success && !options.watch && options.serviceWorker) {

0 commit comments

Comments
 (0)