Skip to content

Commit d609c31

Browse files
committed
fix(@angular-devkit/build-angular): provide better error message when server option is required but missing
This improves the error message when the server entry-point is required but missing Closes #27251 (cherry picked from commit 1034bb1)
1 parent 41aede8 commit d609c31

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

packages/angular_devkit/build_angular/src/builders/application/options.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ export async function normalizeOptions(
238238
if (options.server) {
239239
serverEntryPoint = path.join(workspaceRoot, options.server);
240240
} else if (options.server === '') {
241-
throw new Error('`server` option cannot be an empty string.');
241+
throw new Error('The "server" option cannot be an empty string.');
242242
}
243243

244244
let prerenderOptions;
@@ -270,6 +270,12 @@ export async function normalizeOptions(
270270
};
271271
}
272272

273+
if ((appShellOptions || ssrOptions || prerenderOptions) && !serverEntryPoint) {
274+
throw new Error(
275+
'The "server" option is required when enabling "ssr", "prerender" or "app-shell".',
276+
);
277+
}
278+
273279
// Initial options to keep
274280
const {
275281
allowedCommonJsDependencies,

packages/angular_devkit/build_angular/src/tools/esbuild/application-code-bundle.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -154,15 +154,8 @@ export function createServerCodeBundleOptions(
154154
target: string[],
155155
sourceFileCache: SourceFileCache,
156156
): BuildOptions {
157-
const {
158-
jit,
159-
serverEntryPoint,
160-
workspaceRoot,
161-
ssrOptions,
162-
watch,
163-
externalPackages,
164-
prerenderOptions,
165-
} = options;
157+
const { serverEntryPoint, workspaceRoot, ssrOptions, watch, externalPackages, prerenderOptions } =
158+
options;
166159

167160
assert(
168161
serverEntryPoint,

0 commit comments

Comments
 (0)