refactor(@angular-devkit/benchmark): replace parser with yargs-parser

Author: alan-agius4

Diff for: packages/angular_devkit/benchmark/BUILD.bazel

@@ -25,9 +25,9 @@ ts_library(
     deps = [
         "//packages/angular_devkit/core",
         "//packages/angular_devkit/core/node",
-        "@npm//@types/minimist",
         "@npm//@types/node",
         "@npm//@types/pidusage",
+        "@npm//@types/yargs-parser",
         "@npm//ansi-colors",
         "@npm//rxjs",
     ],
@@ -60,12 +60,12 @@ jasmine_node_test(
     srcs = [":benchmark_test_lib"],
     deps = [
         "@npm//jasmine",
-        "@npm//minimist",
         "@npm//pidtree",
         "@npm//pidusage",
         "@npm//source-map",
         "@npm//temp",
         "@npm//tree-kill",
+        "@npm//yargs-parser",
     ],
 )
 

Diff for: packages/angular_devkit/benchmark/package.json

@@ -12,10 +12,10 @@
   "dependencies": {
     "@angular-devkit/core": "0.0.0-PLACEHOLDER",
     "ansi-colors": "4.1.1",
-    "minimist": "1.2.5",
     "pidusage": "3.0.0",
     "pidtree": "0.5.0",
     "rxjs": "6.6.7",
-    "tree-kill": "^1.2.0"
+    "tree-kill": "^1.2.0",
+    "yargs-parser": "21.0.1"
   }
 }

Diff for: packages/angular_devkit/benchmark/src/main.ts

@@ -11,8 +11,8 @@ import { logging, tags } from '@angular-devkit/core';
 import { ProcessOutput } from '@angular-devkit/core/node';
 import * as ansiColors from 'ansi-colors';
 import { appendFileSync, writeFileSync } from 'fs';
-import minimist from 'minimist';
 import { filter, map, toArray } from 'rxjs/operators';
+import yargsParser from 'yargs-parser';
 import { Command } from '../src/command';
 import { defaultReporter } from '../src/default-reporter';
 import { defaultStatsCapture } from '../src/default-stats-capture';
@@ -25,6 +25,7 @@ export interface MainOptions {
   stderr?: ProcessOutput;
 }
 
+// eslint-disable-next-line max-lines-per-function
 export async function main({
   args,
   stdout = process.stdout,
@@ -69,13 +70,22 @@ export async function main({
     'watch-timeout': number;
     'watch-matcher'?: string;
     'watch-script'?: string;
-    '--': string[] | null;
+    '--': string[];
+    _: string[];
+    $0: string;
   }
 
   // Parse the command line.
-  const argv = minimist(args, {
+  const argv = yargsParser(args, {
     boolean: ['help', 'verbose', 'overwrite-output-file'],
     string: ['watch-matcher', 'watch-script'],
+    configuration: {
+      'dot-notation': false,
+      'boolean-negation': true,
+      'strip-aliased': true,
+      'populate--': true,
+      'camel-case-expansion': false,
+    },
     default: {
       'exit-code': 0,
       'iterations': 5,
@@ -85,8 +95,7 @@ export async function main({
       'prefix': '[benchmark]',
       'watch-timeout': 10000,
     },
-    '--': true,
-  }) as {} as BenchmarkCliArgv;
+  }) as BenchmarkCliArgv;
 
   // Create the DevKit Logger used through the CLI.
   const logger = new logging.TransformLogger('benchmark-prefix-logger', (stream) =>