refactor(@angular-devkit/build-angular): remove host from index writer

Author: alan-agius4

packages/angular_devkit/build_angular/src/browser/index.ts

@@ -732,7 +732,6 @@ export function buildWebpackBrowser(
                 try {
                   if (options.index) {
                     await writeIndexHtml({
-                      host,
                       outputPath: path.join(outputPath, getIndexOutputFile(options.index)),
                       indexPath: path.join(context.workspaceRoot, getIndexInputFile(options.index)),
                       files,

packages/angular_devkit/build_angular/src/utils/fs.ts

@@ -0,0 +1,14 @@
+/**
+ * @license
+ * Copyright Google Inc. All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
+
+import * as fs from 'fs';
+import { promisify } from 'util';
+
+export const mkdir = promisify(fs.mkdir);
+export const readFile = promisify(fs.readFile);
+export const writeFile = promisify(fs.writeFile);

packages/angular_devkit/build_angular/src/utils/index-file/inline-fonts.ts

@@ -7,17 +7,15 @@
  */
 
 import * as cacache from 'cacache';
-import { readFile as readFileAsync } from 'fs';
 import * as https from 'https';
 import { URL } from 'url';
-import { promisify } from 'util';
 import { findCachePath } from '../cache-path';
 import { cachingDisabled } from '../environment-options';
+import { readFile } from '../fs';
 import { htmlRewritingStream } from './html-rewriting-stream';
 
 const cacheFontsPath: string | undefined = cachingDisabled ? undefined : findCachePath('angular-build-fonts');
 const packageVersion = require('../../../package.json').version;
-const readFile = promisify(readFileAsync);
 
 const enum UserAgent {
   Chrome = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.121 Safari/537.36',

packages/angular_devkit/build_angular/src/utils/index-file/write-index-html.ts

@@ -7,17 +7,16 @@
  */
 
 import { EmittedFiles } from '@angular-devkit/build-webpack';
-import { normalize, virtualFs } from '@angular-devkit/core';
 import { dirname, join } from 'path';
 import { ExtraEntryPoint } from '../../browser/schema';
+import { mkdir, readFile, writeFile } from '../fs';
 import { generateEntryPoints } from '../package-chunk-sort';
 import { stripBom } from '../strip-bom';
 import { CrossOriginValue, FileInfo, augmentIndexHtml } from './augment-index-html';
 
 type ExtensionFilter = '.js' | '.css';
 
 export interface WriteIndexHtmlOptions {
-  host: virtualFs.Host;
   outputPath: string;
   indexPath: string;
   files?: EmittedFiles[];
@@ -36,7 +35,6 @@ export interface WriteIndexHtmlOptions {
 export type IndexHtmlTransform = (content: string) => Promise<string>;
 
 export async function writeIndexHtml({
-  host,
   outputPath,
   indexPath,
   files = [],
@@ -51,12 +49,9 @@ export async function writeIndexHtml({
   crossOrigin,
   lang,
 }: WriteIndexHtmlOptions): Promise<void> {
-  const readFile = async (filePath: string) =>
-    virtualFs.fileBufferToString(await host.read(normalize(filePath)).toPromise());
-
   let content = await augmentIndexHtml({
     input: outputPath,
-    inputContent: stripBom(await readFile(indexPath)),
+    inputContent: stripBom(await readFile(indexPath, 'utf-8')),
     baseHref,
     deployUrl,
     crossOrigin,
@@ -66,14 +61,15 @@ export async function writeIndexHtml({
     files: filterAndMapBuildFiles(files, ['.js', '.css']),
     noModuleFiles: filterAndMapBuildFiles(noModuleFiles, '.js'),
     moduleFiles: filterAndMapBuildFiles(moduleFiles, '.js'),
-    loadOutputFile: filePath => readFile(join(dirname(outputPath), filePath)),
+    loadOutputFile: filePath => readFile(join(dirname(outputPath), filePath), 'utf-8'),
   });
 
   for (const transform of postTransforms) {
     content = await transform(content);
   }
 
-  await host.write(normalize(outputPath), virtualFs.stringToFileBuffer(content)).toPromise();
+  await mkdir(dirname(outputPath), { recursive: true });
+  await writeFile(outputPath, content);
 }
 
 function filterAndMapBuildFiles(