Skip to content

Commit 83fab6b

Browse files
alan-agius4filipesilva
authored andcommitted
fix(@angular-devkit/build-angular): improve builder phase reporting
1 parent 371f6eb commit 83fab6b

File tree

19 files changed

+232
-134
lines changed

19 files changed

+232
-134
lines changed

packages/angular_devkit/build_angular/src/app-shell/index.ts

+10-1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import { BrowserBuilderOutput } from '../browser';
1919
import { Schema as BrowserBuilderSchema } from '../browser/schema';
2020
import { ServerBuilderOutput } from '../server';
2121
import { augmentAppWithServiceWorker } from '../utils/service-worker';
22+
import { Spinner } from '../utils/spinner';
2223
import { Schema as BuildWebpackAppShellSchema } from './schema';
2324

2425
async function _renderUniversal(
@@ -152,6 +153,8 @@ async function _appShellBuilder(
152153
watch: false,
153154
});
154155

156+
let spinner: Spinner | undefined;
157+
155158
try {
156159
const [browserResult, serverResult] = await Promise.all([
157160
browserTargetRun.result as unknown as BrowserBuilderOutput,
@@ -164,8 +167,14 @@ async function _appShellBuilder(
164167
return serverResult;
165168
}
166169

167-
return await _renderUniversal(options, context, browserResult, serverResult);
170+
spinner = new Spinner().start('Generating application shell...');
171+
const result = await _renderUniversal(options, context, browserResult, serverResult);
172+
spinner.succeed('Application shell generation complete.');
173+
174+
return result;
168175
} catch (err) {
176+
spinner?.fail('Application shell generation failed.');
177+
169178
return { success: false, error: err.message };
170179
} finally {
171180
// Just be good citizens and stop those jobs.

0 commit comments

Comments
 (0)