refactor(@angular-devkit/build-angular): remove allowed webpack and @angular-devkit/build-angular from CommonJsUsageWarnPlugin

These are no longer needed

Author: alan-agius4

packages/angular_devkit/build_angular/src/dev-server/common-js-warning_spec.ts

@@ -0,0 +1,46 @@
+/**
+ * @license
+ * Copyright Google Inc. All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
+import { Architect } from '@angular-devkit/architect';
+import { logging } from '@angular-devkit/core';
+import { createArchitect, host } from '../test-utils';
+
+describe('Dev Server Builder commonjs warning', () => {
+  const targetSpec = { project: 'app', target: 'serve' };
+
+  let architect: Architect;
+  let logger: logging.Logger;
+  let logs: string[];
+
+  beforeEach(async () => {
+    await host.initialize().toPromise();
+    architect = (await createArchitect(host.root())).architect;
+
+    // Create logger
+    logger = new logging.Logger('');
+    logs = [];
+    logger.subscribe(e => logs.push(e.message));
+  });
+
+  afterEach(async () => host.restore().toPromise());
+
+  it('should not show warning when using HMR', async () => {
+    const run = await architect.scheduleTarget(targetSpec, { hmr: true }, { logger });
+    const output = await run.result;
+    expect(output.success).toBe(true);
+    expect(logs.join()).not.toContain('Warning');
+    await run.stop();
+  });
+
+  it('should not show warning when using live-reload', async () => {
+    const run = await architect.scheduleTarget(targetSpec, { liveReload: true}, { logger });
+    const output = await run.result;
+    expect(output.success).toBe(true);
+    expect(logs.join()).not.toContain('Warning');
+    await run.stop();
+  });
+});

packages/angular_devkit/build_angular/src/webpack/plugins/common-js-usage-warn-plugin.ts

@@ -33,18 +33,10 @@ export interface CommonJsUsageWarnPluginOptions {
 
 export class CommonJsUsageWarnPlugin {
   private shownWarnings = new Set<string>();
-
-  // Allow the below dependency for HMR
-  // tslint:disable-next-line: max-line-length
-  // https://github.com/angular/angular-cli/blob/1e258317b1f6ec1e957ee3559cc3b28ba602f3ba/packages/angular_devkit/build_angular/src/dev-server/index.ts#L605-L638
-  private allowedDependencies = new Set<string>([
-    'webpack/hot/dev-server',
-    'webpack/hot/only-dev-server',
-    '@angular-devkit/build-angular',
-  ]);
+  private allowedDependencies: Set<string>;
 
   constructor(private options: CommonJsUsageWarnPluginOptions = {}) {
-    this.options.allowedDependencies?.forEach(d => this.allowedDependencies.add(d));
+    this.allowedDependencies = new Set(this.options.allowedDependencies);
   }
 
   apply(compiler: Compiler) {
@@ -90,7 +82,7 @@ export class CommonJsUsageWarnPlugin {
             // Only show warnings for modules from main entrypoint.
             // And if the issuer request is not from 'webpack-dev-server', as 'webpack-dev-server'
             // will require CommonJS libraries for live reloading such as 'sockjs-node'.
-            if (mainIssuer?.name === 'main' && !issuer?.userRequest?.includes('webpack-dev-server')) {
+            if (mainIssuer?.name === 'main') {
               const warning = `${issuer?.userRequest} depends on '${rawRequest}'. ` +
                 'CommonJS or AMD dependencies can cause optimization bailouts.\n' +
                 'For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies';