Skip to content

Commit 673030d

Browse files
clydinvikerman
authored andcommitted
fix(@angular-devkit/build-angular): temporarily remove localize peer dependency
This should be reintroduced in 9.1 or 9.2. The other remaining "hidden" peer dependencies should be included as well (currently `karma` and `node-sass`).
1 parent 3f57956 commit 673030d

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

packages/angular_devkit/build_angular/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@
101101
},
102102
"peerDependencies": {
103103
"@angular/compiler-cli": ">=9.0.0-beta < 10",
104-
"@angular/localize": "^9.0.0-next.11",
105104
"typescript": ">=3.6 < 3.7"
106105
},
107106
"peerDependenciesMeta": {

packages/angular_devkit/build_angular/src/utils/load-translations.ts

+6-6
Original file line numberDiff line numberDiff line change
@@ -29,33 +29,33 @@ async function importParsers() {
2929
try {
3030
return {
3131
json: new (await import(
32-
// tslint:disable-next-line:trailing-comma
32+
// tslint:disable-next-line:trailing-comma no-implicit-dependencies
3333
'@angular/localize/src/tools/src/translate/translation_files/translation_parsers/simple_json/simple_json_translation_parser'
3434
)).SimpleJsonTranslationParser(),
3535
xlf: new (await import(
36-
// tslint:disable-next-line:trailing-comma
36+
// tslint:disable-next-line:trailing-comma no-implicit-dependencies
3737
'@angular/localize/src/tools/src/translate/translation_files/translation_parsers/xliff1/xliff1_translation_parser'
3838
)).Xliff1TranslationParser(),
3939
xlf2: new (await import(
40-
// tslint:disable-next-line:trailing-comma
40+
// tslint:disable-next-line:trailing-comma no-implicit-dependencies
4141
'@angular/localize/src/tools/src/translate/translation_files/translation_parsers/xliff2/xliff2_translation_parser'
4242
)).Xliff2TranslationParser(),
4343
};
4444
} catch {
4545
return {
4646
json: new (await import(
4747
// @ts-ignore
48-
// tslint:disable-next-line:trailing-comma
48+
// tslint:disable-next-line:trailing-comma no-implicit-dependencies
4949
'@angular/localize/src/tools/src/translate/translation_files/translation_parsers/simple_json_translation_parser'
5050
)).SimpleJsonTranslationParser(),
5151
xlf: new (await import(
5252
// @ts-ignore
53-
// tslint:disable-next-line:trailing-comma
53+
// tslint:disable-next-line:trailing-comma no-implicit-dependencies
5454
'@angular/localize/src/tools/src/translate/translation_files/translation_parsers/xliff1_translation_parser'
5555
)).Xliff1TranslationParser(),
5656
xlf2: new (await import(
5757
// @ts-ignore
58-
// tslint:disable-next-line:trailing-comma
58+
// tslint:disable-next-line:trailing-comma no-implicit-dependencies
5959
'@angular/localize/src/tools/src/translate/translation_files/translation_parsers/xliff2_translation_parser'
6060
)).Xliff2TranslationParser(),
6161
};

packages/angular_devkit/build_angular/src/utils/process-bundle.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -502,9 +502,10 @@ export async function inlineLocales(options: InlineOptions) {
502502
const { default: MagicString } = await import('magic-string');
503503
const { default: generate } = await import('@babel/generator');
504504
const utils = await import(
505-
// tslint:disable-next-line: trailing-comma
505+
// tslint:disable-next-line: trailing-comma no-implicit-dependencies
506506
'@angular/localize/src/tools/src/translate/source_files/source_file_utils'
507507
);
508+
// tslint:disable-next-line: no-implicit-dependencies
508509
const localizeDiag = await import('@angular/localize/src/tools/src/diagnostics');
509510

510511
const diagnostics = new localizeDiag.Diagnostics();
@@ -594,6 +595,7 @@ function inlineCopyOnly(options: InlineOptions) {
594595

595596
function findLocalizePositions(
596597
options: InlineOptions,
598+
// tslint:disable-next-line: no-implicit-dependencies
597599
utils: typeof import('@angular/localize/src/tools/src/translate/source_files/source_file_utils'),
598600
): LocalizePosition[] {
599601
let ast: ParseResult | undefined | null;

0 commit comments

Comments
 (0)