Skip to content

Commit 64fdb31

Browse files
committed
fix(@angular-devkit/build-angular): exclude node.js built-ins from vite dependency optimization
This fixes the following warnings ``` Cannot optimize dependency: url, present in 'ssr.optimizeDeps.include' Cannot optimize dependency: path, present in 'ssr.optimizeDeps.include' ```
1 parent f06a760 commit 64fdb31

File tree

1 file changed

+7
-4
lines changed
  • packages/angular_devkit/build_angular/src/builders/dev-server

1 file changed

+7
-4
lines changed

packages/angular_devkit/build_angular/src/builders/dev-server/vite-server.ts

+7-4
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,10 @@ export async function setupServer(
390390
join(serverOptions.workspaceRoot, `.angular/vite-root/${randomUUID()}/`),
391391
);
392392

393-
const { builtinModules } = await import('node:module');
393+
const serverExplicitExternal = [
394+
...(await import('node:module')).builtinModules,
395+
...externalMetadata.explicit,
396+
];
394397

395398
const configuration: InlineConfig = {
396399
configFile: false,
@@ -428,12 +431,12 @@ export async function setupServer(
428431
// Note: `true` and `/.*/` have different sematics. When true, the `external` option is ignored.
429432
noExternal: /.*/,
430433
// Exclude any Node.js built in module and provided dependencies (currently build defined externals)
431-
external: [...builtinModules, ...externalMetadata.explicit],
434+
external: serverExplicitExternal,
432435
optimizeDeps: getDepOptimizationConfig({
433436
// Only enable with caching since it causes prebundle dependencies to be cached
434437
disabled: !serverOptions.cacheOptions.enabled,
435-
// Exclude any explicitly defined dependencies (currently build defined externals)
436-
exclude: externalMetadata.explicit,
438+
// Exclude any explicitly defined dependencies (currently build defined externals and node.js built-ins)
439+
exclude: serverExplicitExternal,
437440
// Include all implict dependencies from the external packages internal option
438441
include: externalMetadata.implicitServer,
439442
ssr: true,

0 commit comments

Comments
 (0)