Skip to content

Commit 35c4357

Browse files
authored
test: use random e2e test ports (#23541)
* test: use random e2e test ports * test: use random ng serve ports
1 parent acd5ad5 commit 35c4357

File tree

2 files changed

+10
-2
lines changed
  • packages/angular_devkit/build_angular/src/builders/dev-server/specs
  • tests/legacy-cli/e2e/utils

2 files changed

+10
-2
lines changed

packages/angular_devkit/build_angular/src/builders/dev-server/specs/works_spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ describe('Dev Server Builder', () => {
3434
expect(output.success).toBe(true);
3535

3636
// When webpack-dev-server doesn't have `contentBase: false`, this will serve the repo README.
37-
const response = await fetch('http://localhost:4200/README.md', {
37+
const response = await fetch(`http://localhost:${output.port}/README.md`, {
3838
headers: {
3939
'Accept': 'text/html',
4040
},

tests/legacy-cli/e2e/utils/project.ts

+9-1
Original file line numberDiff line numberDiff line change
@@ -165,9 +165,17 @@ export function useCIDefaults(projectName = 'test-project') {
165165
const appTargets = project.targets || project.architect;
166166
appTargets.build.options.progress = false;
167167
appTargets.test.options.progress = false;
168-
// Disable auto-updating webdriver in e2e.
169168
if (appTargets.e2e) {
169+
// Disable auto-updating webdriver in e2e.
170170
appTargets.e2e.options.webdriverUpdate = false;
171+
// Use a random port in e2e.
172+
appTargets.e2e.options.port = 0;
173+
}
174+
175+
if (appTargets.serve) {
176+
// Use a random port in serve.
177+
appTargets.serve.options ??= {};
178+
appTargets.serve.options.port = 0;
171179
}
172180
});
173181
}

0 commit comments

Comments
 (0)