Skip to content

Commit 2a8534a

Browse files
dgp1130clydin
authored andcommitted
docs: clarify that version bumps must happen separately from the release PR
In `14.2.0`, we learned that we can't bump peer deps / `latest-versions.ts` in a release PR, because the released NPM artifact is actually built *before* an opportunity to edit the PR appears. We need to do a separate before the CLI release to make this change. See: https://angular-team.slack.com/archives/C46U16D4Z/p1661482133013029
1 parent 91133fc commit 2a8534a

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

docs/process/release.md

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -71,19 +71,20 @@ Releasing is performed using Angular's unified release tooling. Each week, two r
7171

7272
**For a minor OR major release:**
7373

74-
After FW releases `-rc.0` for an upcoming minor/major version, update the corresponding version in
75-
[`latest-versions.ts`](/packages/schematics/angular/utility/latest-versions.ts#L=18) **and** peer
76-
dependencies on FW ([here](/packages/angular_devkit/build_angular/package.json) and
77-
[here](/packages/ngtools/webpack/package.json)) to match. This ensures that CLI `-rc.0` depends on
78-
FW `-rc.0`.
74+
After FW releases `-rc.0` for an upcoming minor/major version, update the corresponding version in:
75+
76+
- [`latest-versions.ts`](/packages/schematics/angular/utility/latest-versions.ts#L=18)
77+
- [`@angular-devkit/build-angular`](/packages/angular_devkit/build_angular/package.json)
78+
- [`@ngtools/webpack`](/packages/ngtools/webpack/package.json)
7979

8080
The same needs to be done for a `-next.0` release, and needs to be done for both minor _and_ major
8181
releases.
8282

8383
Once FW releases the actual minor/major release (for example: `13.0.0` or `13.1.0`), these versions
84-
should be updated to match (remove `-rc.0` and `-next.0`). This can be done as part of the release
85-
PR ([example](https://github.com/angular/angular-cli/pull/22580/files#diff-53a0da39e6b029472ba808fdd567f8706e752434fa51be6009f0140532b9fe2f))
86-
or a separate PR after FW releases but before CLI releases.
84+
should be updated to match (remove `-rc.0` and `-next.0`). This **must** be done as a separate PR
85+
which lands after FW releases (or else CI will fail) but _before_ the CLI release PR. Releases are
86+
built before the PR is sent for review, so any changes after that point won't be included in the
87+
release.
8788

8889
**For a major release:**
8990

0 commit comments

Comments
 (0)