Skip to content

Commit 20e48a3

Browse files
alan-agius4filipesilva
authored andcommitted
feat(@angular-devkit/build-angular): remove deprecated options
BREAKING CHANGE: With this change we removed several deprecated builder options - `extractCss` has been removed from the browser builder. CSS is now always extracted. - `servePathDefaultWarning` and `hmrWarning` have been removed from the dev-server builder. These options had no effect.
1 parent de1d21a commit 20e48a3

File tree

29 files changed

+461
-553
lines changed

29 files changed

+461
-553
lines changed

goldens/public-api/angular_devkit/build_angular/src/index.md

-2
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ export interface BrowserBuilderOptions {
4040
crossOrigin?: CrossOrigin;
4141
deleteOutputPath?: boolean;
4242
deployUrl?: string;
43-
// @deprecated
44-
extractCss?: boolean;
4543
extractLicenses?: boolean;
4644
fileReplacements?: FileReplacement[];
4745
i18nMissingTranslation?: I18NMissingTranslation;

package.json

-1
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,6 @@
211211
"source-map-loader": "3.0.0",
212212
"source-map-support": "0.5.19",
213213
"spdx-satisfies": "^5.0.0",
214-
"style-loader": "3.2.1",
215214
"stylus": "0.54.8",
216215
"stylus-loader": "6.1.0",
217216
"symbol-observable": "4.0.0",

packages/angular_devkit/build_angular/BUILD.bazel

-1
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,6 @@ ts_library(
173173
"@npm//semver",
174174
"@npm//source-map-loader",
175175
"@npm//source-map-support",
176-
"@npm//style-loader",
177176
"@npm//stylus",
178177
"@npm//stylus-loader",
179178
"@npm//terser",

packages/angular_devkit/build_angular/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@
6262
"semver": "7.3.5",
6363
"source-map-loader": "3.0.0",
6464
"source-map-support": "0.5.19",
65-
"style-loader": "3.2.1",
6665
"stylus": "0.54.8",
6766
"stylus-loader": "6.1.0",
6867
"terser": "5.7.1",

packages/angular_devkit/build_angular/src/browser/schema.json

-6
Original file line numberDiff line numberDiff line change
@@ -237,12 +237,6 @@
237237
}
238238
]
239239
},
240-
"extractCss": {
241-
"type": "boolean",
242-
"description": "Extract CSS from global styles into '.css' files instead of '.js'.",
243-
"default": true,
244-
"x-deprecated": "Deprecated since version 11.0. No longer required to disable CSS extraction for HMR."
245-
},
246240
"watch": {
247241
"type": "boolean",
248242
"description": "Run build when files change.",

packages/angular_devkit/build_angular/src/browser/specs/optimization-level_spec.ts

-2
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ describe('Browser Builder optimization level', () => {
4141
scripts: false,
4242
},
4343
aot: true,
44-
extractCss: true,
4544
styles: ['src/styles.css'],
4645
};
4746

@@ -64,7 +63,6 @@ describe('Browser Builder optimization level', () => {
6463
scripts: true,
6564
},
6665
aot: true,
67-
extractCss: true,
6866
styles: ['src/styles.css'],
6967
};
7068

packages/angular_devkit/build_angular/src/browser/specs/resources-output-path_spec.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ describe('Browser Builder styles resources output path', () => {
4949
// Check base paths are correctly generated.
5050
const overrides = {
5151
aot: true,
52-
extractCss: true,
5352
resourcesOutputPath: 'out-assets',
5453
};
5554

@@ -78,7 +77,7 @@ describe('Browser Builder styles resources output path', () => {
7877
writeFiles();
7978

8079
// Check base paths are correctly generated.
81-
const overrides = { aot: true, extractCss: true };
80+
const overrides = { aot: true };
8281
const { files } = await browserBuild(architect, host, target, overrides);
8382
const styles = await files['styles.css'];
8483
const main = await files['main.js'];

packages/angular_devkit/build_angular/src/browser/specs/source-map_spec.ts

-6
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ describe('Browser Builder source map', () => {
2323
it('works', async () => {
2424
const overrides = {
2525
sourceMap: true,
26-
extractCss: true,
2726
styles: ['src/styles.css'],
2827
};
2928

@@ -77,7 +76,6 @@ describe('Browser Builder source map', () => {
7776
styles: true,
7877
scripts: true,
7978
},
80-
extractCss: true,
8179
styles: ['src/styles.scss'],
8280
};
8381

@@ -98,7 +96,6 @@ describe('Browser Builder source map', () => {
9896
styles: true,
9997
scripts: false,
10098
},
101-
extractCss: true,
10299
styles: ['src/styles.scss'],
103100
};
104101

@@ -119,7 +116,6 @@ describe('Browser Builder source map', () => {
119116
styles: false,
120117
scripts: true,
121118
},
122-
extractCss: true,
123119
styles: ['src/styles.scss'],
124120
};
125121

@@ -141,7 +137,6 @@ describe('Browser Builder source map', () => {
141137
styles: true,
142138
scripts: true,
143139
},
144-
extractCss: true,
145140
styles: ['src/styles.scss'],
146141
};
147142

@@ -162,7 +157,6 @@ describe('Browser Builder source map', () => {
162157
it('should resolve sources to partial SCSS files', async () => {
163158
const overrides = {
164159
sourceMap: true,
165-
extractCss: true,
166160
styles: ['src/styles.scss'],
167161
};
168162

0 commit comments

Comments
 (0)