refactor(@angular-devkit/architect): assert catch clause variable type before usage

Prepares the `@angular-devkit/architect` package for the eventual change of enabling the
TypeScript `useUnknownInCatchVariables` option. This option provides additional
code safety by ensuring that the catch clause variable is the proper type before
attempting to access its properties. Similar changes will be needed in the other
packages in the repository prior to enabling `useUnknownInCatchVariables`.

Author: clydin

packages/angular_devkit/architect/node/node-modules-architect-host.ts

@@ -245,7 +245,7 @@ async function getBuilder(builderPath: string): Promise<any> {
       try {
         return require(builderPath);
       } catch (e) {
-        if (e.code === 'ERR_REQUIRE_ESM') {
+        if ((e as NodeJS.ErrnoException).code === 'ERR_REQUIRE_ESM') {
           // Load the ESM configuration file using the TypeScript dynamic import workaround.
           // Once TypeScript provides support for keeping the dynamic import this workaround can be
           // changed to a direct dynamic import.

packages/angular_devkit/architect/src/index_spec.ts

@@ -136,13 +136,10 @@ describe('architect', () => {
     await run.stop();
   });
 
-  it(`errors when target configuration doesn't exists`, async () => {
-    try {
-      await architect.scheduleBuilder('test:test:invalid', {});
-      throw new Error('should have thrown');
-    } catch (err) {
-      expect(err.message).toContain('Job name "test:test:invalid" does not exist.');
-    }
+  it(`errors when target configuration does not exist`, async () => {
+    await expectAsync(architect.scheduleBuilder('test:test:invalid', {})).toBeRejectedWithError(
+      'Job name "test:test:invalid" does not exist.',
+    );
   });
 
   it('errors when builder cannot be resolved', async () => {

packages/angular_devkit/architect_cli/bin/architect.ts

@@ -179,7 +179,7 @@ async function _executeTarget(
     logs.forEach((l) => parentLogger.next(l));
 
     parentLogger.fatal('Exception:');
-    parentLogger.fatal(err.stack);
+    parentLogger.fatal((err instanceof Error && err.stack) || `${err}`);
 
     return 2;
   }