build: enable TypeScript useUnknownInCatchVariables compiler option

clydin · alan-agius4 · commit 0b7f5d315e6d · 2022-06-14T11:28:21.000+02:00
Enables the TypeScript `useUnknownInCatchVariables` option. This option
provides additional code safety by ensuring that the catch clause variable
is the proper type before attempting to access its properties.
diff --git a/packages/angular_devkit/benchmark/src/main.ts b/packages/angular_devkit/benchmark/src/main.ts
@@ -221,11 +221,7 @@ export async function main({
       return 1;
     }
   } catch (error) {
-    if (error.message) {
-      logger.fatal(error.message);
-    } else {
-      logger.fatal(error);
-    }
+    logger.fatal(error instanceof Error ? error.message : `${error}`);
 
     return 1;
   }
diff --git a/tsconfig.json b/tsconfig.json
@@ -10,7 +10,6 @@
     "noImplicitOverride": true,
     "noUnusedParameters": false,
     "noUnusedLocals": false,
-    "useUnknownInCatchVariables": false,
     "outDir": "./dist",
     "rootDir": ".",
     "skipLibCheck": true,

Original file line number	Diff line number	Diff line change
`@@ -221,11 +221,7 @@ export async function main({`
`221`	`221`	`return 1;`
`222`	`222`	`}`
`223`	`223`	`} catch (error) {`
`224`		`- if (error.message) {`
`225`		`- logger.fatal(error.message);`
`226`		`- } else {`
`227`		`- logger.fatal(error);`
`228`		`- }`
	`224`	+ logger.fatal(error instanceof Error ? error.message : `${error}`);
`229`	`225`
`230`	`226`	`return 1;`
`231`	`227`	`}`