Skip to content

Commit 09d2f04

Browse files
alan-agius4mgechev
authored andcommitted
fix(@angular-devkit/build-angular): update worker-plugin to 3.2.0 (#15456)
includes this fix GoogleChromeLabs/worker-plugin#35 which solves the below issues. Fixes #15188 and fixes #14582
1 parent 4df025f commit 09d2f04

File tree

3 files changed

+6
-15
lines changed

3 files changed

+6
-15
lines changed

packages/angular_devkit/build_angular/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
"webpack-sources": "1.4.3",
6262
"webpack-subresource-integrity": "1.1.0-rc.6",
6363
"worker-farm": "1.7.0",
64-
"worker-plugin": "3.1.0"
64+
"worker-plugin": "3.2.0"
6565
},
6666
"devDependencies": {
6767
"@angular/animations": "~9.0.0-next.3",

packages/angular_devkit/build_angular/test/browser/web-worker_spec_large.ts

+1-10
Original file line numberDiff line numberDiff line change
@@ -162,17 +162,8 @@ describe('Browser Builder Web Worker support', () => {
162162

163163
case 2:
164164
workerContent = virtualFs.fileBufferToString(host.scopedSync().read(workerPath));
165-
// TODO(filipesilva): Should this change? Check with Jason Miller.
166-
// The worker changes name with each rebuild. But sometimes it also changes from 0 to
167-
// 1 and then back to 0. It's hard to know where the updated content is, but it should
168-
// be in one of these two.
169-
const anotherWorkerPath = join(outputPath, '1.worker.js');
170-
const anotherWorkerContent = virtualFs.fileBufferToString(
171-
host.scopedSync().read(anotherWorkerPath));
172165
// Worker content should have changed.
173-
expect(
174-
workerContent.includes('baz') || anotherWorkerContent.includes('baz'),
175-
).toBeTruthy('Worker bundle did not contain updated content.');
166+
expect(workerContent).toContain('baz');
176167
phase = 3;
177168
break;
178169
}

yarn.lock

+4-4
Original file line numberDiff line numberDiff line change
@@ -12279,10 +12279,10 @@ worker-farm@1.7.0, worker-farm@^1.7.0:
1227912279
dependencies:
1228012280
errno "~0.1.7"
1228112281

12282-
worker-plugin@3.1.0:
12283-
version "3.1.0"
12284-
resolved "https://registry.yarnpkg.com/worker-plugin/-/worker-plugin-3.1.0.tgz#6311778f3514a87c273510ee3f809cc3fe161e6f"
12285-
integrity sha512-iQ9KTTmmN5fhfc2KMR7CcDblvcrg1QQ4pXymqZ3cRZF8L0890YLBcEqlIsGPdxoFwghyN8RA1pCEhCKuTF4Lkw==
12282+
worker-plugin@3.2.0:
12283+
version "3.2.0"
12284+
resolved "https://registry.yarnpkg.com/worker-plugin/-/worker-plugin-3.2.0.tgz#ddae9f161b76fcbaacf8f54ecd037844584e43e7"
12285+
integrity sha512-W5nRkw7+HlbsEt3qRP6MczwDDISjiRj2GYt9+bpe8A2La00TmJdwzG5bpdMXhRt1qcWmwAvl1TiKaHRa+XDS9Q==
1228612286
dependencies:
1228712287
loader-utils "^1.1.0"
1228812288

0 commit comments

Comments
 (0)