Skip to content

Commit b639fcc

Browse files
committed
build: avoid use of ts-node wrapper script as it breaks child process forking (angular#25141)
`ts-node` spawns a custom node launcher script and has a brotli-base64 encoded configuration that will point to the user-provided entry-point. This breaks child process forking as we wouldn't be able to specify our custom build worker and basically `ng-dev` would run inside `ng-dev` again. (cherry picked from commit 854a45c)
1 parent 8df5efe commit b639fcc

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
},
1616
"scripts": {
1717
"postinstall": "node tools/postinstall/apply-patches.js",
18-
"ng-dev": "ts-node --esm --project .ng-dev/tsconfig.json node_modules/@angular/dev-infra-private/ng-dev/bundles/cli.mjs",
18+
"ng-dev": "cross-env TS_NODE_PROJECT=$PWD/.ng-dev/tsconfig.json TS_NODE_TRANSPILE_ONLY=1 node --no-warnings --loader ts-node/esm node_modules/@angular/dev-infra-private/ng-dev/bundles/cli.mjs",
1919
"build": "ts-node --esm --project scripts/tsconfig.json ./scripts/build-packages-dist-main.mts",
2020
"build-docs-content": "ts-node --esm --project scripts/tsconfig.json ./scripts/build-docs-content-main.mts",
2121
"build-and-check-release-output": "ts-node --esm --project scripts/tsconfig.json scripts/build-and-check-release-output.mts",
@@ -166,6 +166,7 @@
166166
"browser-sync": "2.26.13",
167167
"chalk": "^4.1.0",
168168
"codelyzer": "^6.0.2",
169+
"cross-env": "^7.0.3",
169170
"date-fns": "^2.28.0",
170171
"dgeni": "^0.4.14",
171172
"dgeni-packages": "^0.29.3",

yarn.lock

+7-1
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,6 @@
329329

330330
"@angular/dev-infra-private@https://github.com/angular/dev-infra-private-builds.git#f2ca0a57e8ede868dc51c3b80a0d3ca56d5fdf65":
331331
version "0.0.0-04a54cdfa050a7b6ed1dab8f0054f85022827ed5"
332-
uid f2ca0a57e8ede868dc51c3b80a0d3ca56d5fdf65
333332
resolved "https://github.com/angular/dev-infra-private-builds.git#f2ca0a57e8ede868dc51c3b80a0d3ca56d5fdf65"
334333
dependencies:
335334
"@angular-devkit/build-angular" "14.1.0-next.1"
@@ -6415,6 +6414,13 @@ cross-env@^5.1.3:
64156414
dependencies:
64166415
cross-spawn "^6.0.5"
64176416

6417+
cross-env@^7.0.3:
6418+
version "7.0.3"
6419+
resolved "https://registry.yarnpkg.com/cross-env/-/cross-env-7.0.3.tgz#865264b29677dc015ba8418918965dd232fc54cf"
6420+
integrity sha512-+/HKd6EgcQCJGh2PSjZuUitQBQynKor4wrFbRg4DtAgS1aWO+gU52xpH7M9ScGgXSYmAVS9bIJ8EzuaGw0oNAw==
6421+
dependencies:
6422+
cross-spawn "^7.0.1"
6423+
64186424
cross-spawn@^5.0.1:
64196425
version "5.1.0"
64206426
resolved "https://registry.yarnpkg.com/cross-spawn/-/cross-spawn-5.1.0.tgz#e8bd0efee58fcff6f8f94510a0a554bbfa235449"

0 commit comments

Comments
 (0)