forked from swiftlang/swift
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathVerifier.swift
267 lines (230 loc) · 8.73 KB
/
Verifier.swift
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
//===--- Verifier.swift ---------------------------------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2024 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
import SIL
import OptimizerBridging
private protocol VerifiableInstruction : Instruction {
func verify(_ context: FunctionPassContext)
}
private func require(_ condition: Bool, _ message: @autoclosure () -> String, atInstruction: Instruction? = nil) {
if !condition {
let msg = message()
msg._withBridgedStringRef { stringRef in
verifierError(stringRef, atInstruction.bridged, Optional<Argument>.none.bridged)
}
}
}
extension Function {
func verify(_ context: FunctionPassContext) {
for block in blocks {
for arg in block.arguments {
arg.verify(context)
}
for inst in block.instructions {
inst.checkForwardingConformance()
inst.checkGuaranteedResults()
if let verifiableInst = inst as? VerifiableInstruction {
verifiableInst.verify(context)
}
}
}
}
}
private extension Instruction {
func checkForwardingConformance() {
if bridged.shouldBeForwarding() {
require(self is ForwardingInstruction, "instruction \(self)\nshould conform to ForwardingInstruction")
} else {
require(!(self is ForwardingInstruction), "instruction \(self)\nshould not conform to ForwardingInstruction")
}
}
func checkGuaranteedResults() {
for result in results where result.ownership == .guaranteed {
require(BeginBorrowValue(result) != nil || self is ForwardingInstruction,
"\(result) must either be a BeginBorrowValue or a ForwardingInstruction")
}
}
}
private extension Argument {
func verify(_ context: FunctionPassContext) {
if let phi = Phi(self), phi.value.ownership == .guaranteed {
phi.verifyBorrowedFromUse()
require(phi.isReborrow == phi.hasBorrowEndingUse ||
// In a dead-end block an end_borrow might have been deleted.
// TODO: this check is not needed anymore once we have complete OSSA lifetimes.
(isReborrow && context.deadEndBlocks.isDeadEnd(parentBlock)),
"\(self) has stale reborrow flag");
}
}
}
private extension Phi {
func verifyBorrowedFromUse() {
var forwardingBorrowedFromFound = false
for use in value.uses {
require(use.instruction is BorrowedFromInst,
"guaranteed phi: \(self)\n has non borrowed-from use: \(use)")
if use.index == 0 {
require(!forwardingBorrowedFromFound, "phi \(self) has multiple forwarding borrowed-from uses")
forwardingBorrowedFromFound = true
}
}
require(forwardingBorrowedFromFound,
"missing forwarding borrowed-from user of guaranteed phi \(self)")
}
}
extension BorrowedFromInst : VerifiableInstruction {
func verify(_ context: FunctionPassContext) {
for ev in enclosingValues {
require(ev.isValidEnclosingValueInBorrowedFrom, "invalid enclosing value in borrowed-from: \(ev)")
}
var computedEVs = Stack<Value>(context)
defer { computedEVs.deinitialize() }
guard let phi = Phi(borrowedValue) else {
fatalError("borrowed value of borrowed-from must be a phi: \(self)")
}
gatherEnclosingValuesFromPredecessors(for: phi, in: &computedEVs, context)
var existingEVs = ValueSet(insertContentsOf: enclosingValues, context)
defer { existingEVs.deinitialize() }
for computedEV in computedEVs {
require(existingEVs.contains(computedEV),
"\(computedEV)\n missing in enclosing values of \(self)")
}
}
}
private extension Value {
var isValidEnclosingValueInBorrowedFrom: Bool {
switch ownership {
case .owned:
return true
case .guaranteed:
return BeginBorrowValue(self) != nil ||
self is BorrowedFromInst ||
forwardingInstruction != nil
case .none, .unowned:
return false
}
}
}
extension LoadBorrowInst : VerifiableInstruction {
func verify(_ context: FunctionPassContext) {
if isUnchecked {
return
}
var mutatingInstructions = MutatingUsesWalker(context)
defer { mutatingInstructions.deinitialize() }
mutatingInstructions.findMutatingUses(of: self.address)
mutatingInstructions.verifyNoMutatingUsesInLiverange(of: self)
}
}
// Used to check if any instruction is mutating the memory location within the liverange of a `load_borrow`.
// Note that it is not checking if an instruction _may_ mutate the memory, but it's checking if any instruction
// _definitely_ will mutate the memory.
// Otherwise the risk would be too big for false alarms. It also means that this verification is not perfect and
// might miss some subtle violations.
private struct MutatingUsesWalker : AddressDefUseWalker {
let context: FunctionPassContext
var mutatingInstructions: InstructionSet
init(_ context: FunctionPassContext) {
self.context = context
self.mutatingInstructions = InstructionSet(context)
}
mutating func deinitialize() {
self.mutatingInstructions.deinitialize()
}
mutating func findMutatingUses(of address: Value) {
_ = walkDownUses(ofAddress: address, path: UnusedWalkingPath())
}
mutating func verifyNoMutatingUsesInLiverange(of load: LoadBorrowInst) {
// The liverange of a `load_borrow` can end in a branch instruction. In such cases we handle the re-borrow liveranges
// (starting at the `borrowed_from` in the successor block) separately.
// This worklist contains the starts of the individual linear liveranges,
// i.e. `load_borrow` and `borrowed_from` instructions.
var linearLiveranges = SpecificInstructionWorklist<SingleValueInstruction>(context)
defer { linearLiveranges.deinitialize() }
linearLiveranges.pushIfNotVisited(load)
while let startInst = linearLiveranges.pop() {
verifyNoMutatingUsesInLinearLiverange(of: startInst)
for use in startInst.uses {
if let phi = Phi(using: use) {
if let bf = phi.borrowedFrom {
linearLiveranges.pushIfNotVisited(bf)
} else {
require(false, "missing borrowed-from for \(phi.value)")
}
}
}
}
}
private mutating func verifyNoMutatingUsesInLinearLiverange(of startInst: SingleValueInstruction) {
assert(startInst is LoadBorrowInst || startInst is BorrowedFromInst)
var instWorklist = InstructionWorklist(context)
defer { instWorklist.deinitialize() }
// It would be good enough to only consider `end_borrow`s (and branches), but adding all users doesn't harm.
for use in startInst.uses {
instWorklist.pushPredecessors(of: use.instruction, ignoring: startInst)
}
while let inst = instWorklist.pop() {
require(!mutatingInstructions.contains(inst),
"Load borrow invalidated by a local write", atInstruction: inst)
instWorklist.pushPredecessors(of: inst, ignoring: startInst)
}
}
mutating func leafUse(address: Operand, path: UnusedWalkingPath) -> WalkResult {
if address.isMutatedAddress {
mutatingInstructions.insert(address.instruction)
}
return .continueWalk
}
}
private extension Operand {
// Returns true if the operand's instruction is definitely writing to the operand's address value.
var isMutatedAddress: Bool {
assert(value.type.isAddress)
switch instruction {
case let store as StoringInstruction:
return self == store.destinationOperand
case let copy as SourceDestAddrInstruction:
if self == copy.destinationOperand {
return true
} else if self == copy.sourceOperand && copy.isTakeOfSrc {
return true
}
return false
case let load as LoadInst:
return load.loadOwnership == .take
case let partialApply as PartialApplyInst:
if !partialApply.isOnStack,
let convention = partialApply.convention(of: self)
{
switch convention {
case .indirectIn, .indirectInGuaranteed:
// Such operands are consumed by the `partial_apply` and therefore cound as "written".
return true
default:
return false
}
}
return false
case is DestroyAddrInst, is IsUniqueInst:
return true
default:
return false
}
}
}
func registerVerifier() {
BridgedUtilities.registerVerifier(
{ (bridgedCtxt: BridgedPassContext, bridgedFunction: BridgedFunction) in
let context = FunctionPassContext(_bridged: bridgedCtxt)
bridgedFunction.function.verify(context)
}
)
}