Update misspelling 'identifer' to 'identifier' (microsoft#30894)

postama · RyanCavanaugh · commit e9514552153f · 2019-04-12T13:29:00.000-07:00
* fix typo - identifer to identifier

* fix typo - identifer to identifier
diff --git a/lib/tsserver.js b/lib/tsserver.js
@@ -33624,7 +33624,7 @@ var ts;
             return type;
         }
         // A reserved member name starts with two underscores, but the third character cannot be an underscore
-        // or the @ symbol. A third underscore indicates an escaped form of an identifer that started
+        // or the @ symbol. A third underscore indicates an escaped form of an identifier that started
         // with at least two underscores. The @ character indicates that the name is denoted by a well known ES
         // Symbol instance.
         function isReservedMemberName(name) {
@@ -99911,9 +99911,9 @@ var ts;
                 || ts.isKnownSymbol(symbol)) {
                 return undefined;
             }
-            var validIdentiferResult = { name: name, needsConvertPropertyAccess: false };
+            var validIdentifierResult = { name: name, needsConvertPropertyAccess: false };
             if (ts.isIdentifierText(name, target))
-                return validIdentiferResult;
+                return validIdentifierResult;
             switch (kind) {
                 case 3 /* MemberLike */:
                     return undefined;
@@ -99926,7 +99926,7 @@ var ts;
                     return name.charCodeAt(0) === 32 /* space */ ? undefined : { name: name, needsConvertPropertyAccess: true };
                 case 5 /* None */:
                 case 4 /* String */:
-                    return validIdentiferResult;
+                    return validIdentifierResult;
                 default:
                     ts.Debug.assertNever(kind);
             }
diff --git a/lib/tsserverlibrary.js b/lib/tsserverlibrary.js
@@ -33623,7 +33623,7 @@ var ts;
             return type;
         }
         // A reserved member name starts with two underscores, but the third character cannot be an underscore
-        // or the @ symbol. A third underscore indicates an escaped form of an identifer that started
+        // or the @ symbol. A third underscore indicates an escaped form of an identifier that started
         // with at least two underscores. The @ character indicates that the name is denoted by a well known ES
         // Symbol instance.
         function isReservedMemberName(name) {
@@ -100250,9 +100250,9 @@ var ts;
                 || ts.isKnownSymbol(symbol)) {
                 return undefined;
             }
-            var validIdentiferResult = { name: name, needsConvertPropertyAccess: false };
+            var validIdentifierResult = { name: name, needsConvertPropertyAccess: false };
             if (ts.isIdentifierText(name, target))
-                return validIdentiferResult;
+                return validIdentifierResult;
             switch (kind) {
                 case 3 /* MemberLike */:
                     return undefined;
@@ -100265,7 +100265,7 @@ var ts;
                     return name.charCodeAt(0) === 32 /* space */ ? undefined : { name: name, needsConvertPropertyAccess: true };
                 case 5 /* None */:
                 case 4 /* String */:
-                    return validIdentiferResult;
+                    return validIdentifierResult;
                 default:
                     ts.Debug.assertNever(kind);
             }
diff --git a/lib/typescript.js b/lib/typescript.js
@@ -33614,7 +33614,7 @@ var ts;
             return type;
         }
         // A reserved member name starts with two underscores, but the third character cannot be an underscore
-        // or the @ symbol. A third underscore indicates an escaped form of an identifer that started
+        // or the @ symbol. A third underscore indicates an escaped form of an identifier that started
         // with at least two underscores. The @ character indicates that the name is denoted by a well known ES
         // Symbol instance.
         function isReservedMemberName(name) {
@@ -100241,9 +100241,9 @@ var ts;
                 || ts.isKnownSymbol(symbol)) {
                 return undefined;
             }
-            var validIdentiferResult = { name: name, needsConvertPropertyAccess: false };
+            var validIdentifierResult = { name: name, needsConvertPropertyAccess: false };
             if (ts.isIdentifierText(name, target))
-                return validIdentiferResult;
+                return validIdentifierResult;
             switch (kind) {
                 case 3 /* MemberLike */:
                     return undefined;
@@ -100256,7 +100256,7 @@ var ts;
                     return name.charCodeAt(0) === 32 /* space */ ? undefined : { name: name, needsConvertPropertyAccess: true };
                 case 5 /* None */:
                 case 4 /* String */:
-                    return validIdentiferResult;
+                    return validIdentifierResult;
                 default:
                     ts.Debug.assertNever(kind);
             }
diff --git a/lib/typescriptServices.js b/lib/typescriptServices.js
@@ -33614,7 +33614,7 @@ var ts;
             return type;
         }
         // A reserved member name starts with two underscores, but the third character cannot be an underscore
-        // or the @ symbol. A third underscore indicates an escaped form of an identifer that started
+        // or the @ symbol. A third underscore indicates an escaped form of an identifier that started
         // with at least two underscores. The @ character indicates that the name is denoted by a well known ES
         // Symbol instance.
         function isReservedMemberName(name) {
@@ -100241,9 +100241,9 @@ var ts;
                 || ts.isKnownSymbol(symbol)) {
                 return undefined;
             }
-            var validIdentiferResult = { name: name, needsConvertPropertyAccess: false };
+            var validIdentifierResult = { name: name, needsConvertPropertyAccess: false };
             if (ts.isIdentifierText(name, target))
-                return validIdentiferResult;
+                return validIdentifierResult;
             switch (kind) {
                 case 3 /* MemberLike */:
                     return undefined;
@@ -100256,7 +100256,7 @@ var ts;
                     return name.charCodeAt(0) === 32 /* space */ ? undefined : { name: name, needsConvertPropertyAccess: true };
                 case 5 /* None */:
                 case 4 /* String */:
-                    return validIdentiferResult;
+                    return validIdentifierResult;
                 default:
                     ts.Debug.assertNever(kind);
             }
diff --git a/lib/typingsInstaller.js b/lib/typingsInstaller.js
@@ -33615,7 +33615,7 @@ var ts;
             return type;
         }
         // A reserved member name starts with two underscores, but the third character cannot be an underscore
-        // or the @ symbol. A third underscore indicates an escaped form of an identifer that started
+        // or the @ symbol. A third underscore indicates an escaped form of an identifier that started
         // with at least two underscores. The @ character indicates that the name is denoted by a well known ES
         // Symbol instance.
         function isReservedMemberName(name) {
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -2843,7 +2843,7 @@ namespace ts {
         }
 
         // A reserved member name starts with two underscores, but the third character cannot be an underscore
-        // or the @ symbol. A third underscore indicates an escaped form of an identifer that started
+        // or the @ symbol. A third underscore indicates an escaped form of an identifier that started
         // with at least two underscores. The @ character indicates that the name is denoted by a well known ES
         // Symbol instance.
         function isReservedMemberName(name: __String) {
diff --git a/src/services/completions.ts b/src/services/completions.ts
@@ -1912,8 +1912,8 @@ namespace ts.Completions {
             return undefined;
         }
 
-        const validIdentiferResult: CompletionEntryDisplayNameForSymbol = { name, needsConvertPropertyAccess: false };
-        if (isIdentifierText(name, target)) return validIdentiferResult;
+        const validIdentifierResult: CompletionEntryDisplayNameForSymbol = { name, needsConvertPropertyAccess: false };
+        if (isIdentifierText(name, target)) return validIdentifierResult;
         switch (kind) {
             case CompletionKind.MemberLike:
                 return undefined;
@@ -1926,7 +1926,7 @@ namespace ts.Completions {
                 return name.charCodeAt(0) === CharacterCodes.space ? undefined : { name, needsConvertPropertyAccess: true };
             case CompletionKind.None:
             case CompletionKind.String:
-                return validIdentiferResult;
+                return validIdentifierResult;
             default:
                 Debug.assertNever(kind);
         }
diff --git a/tests/baselines/reference/genericClassesRedeclaration.errors.txt b/tests/baselines/reference/genericClassesRedeclaration.errors.txt
@@ -1,8 +1,8 @@
 tests/cases/compiler/genericClassesRedeclaration.ts(16,11): error TS2300: Duplicate identifier 'StringHashTable'.
-tests/cases/compiler/genericClassesRedeclaration.ts(29,11): error TS2300: Duplicate identifier 'IdentiferNameHashTable'.
+tests/cases/compiler/genericClassesRedeclaration.ts(29,11): error TS2300: Duplicate identifier 'IdentifierNameHashTable'.
 tests/cases/compiler/genericClassesRedeclaration.ts(42,9): error TS2374: Duplicate string index signature.
 tests/cases/compiler/genericClassesRedeclaration.ts(55,11): error TS2300: Duplicate identifier 'StringHashTable'.
-tests/cases/compiler/genericClassesRedeclaration.ts(68,11): error TS2300: Duplicate identifier 'IdentiferNameHashTable'.
+tests/cases/compiler/genericClassesRedeclaration.ts(68,11): error TS2300: Duplicate identifier 'IdentifierNameHashTable'.
 
 
 ==== tests/cases/compiler/genericClassesRedeclaration.ts (5 errors) ====
@@ -36,9 +36,9 @@ tests/cases/compiler/genericClassesRedeclaration.ts(68,11): error TS2300: Duplic
             public lookup(key: string): T;
             public remove(key: string): void;
         }
-        class IdentiferNameHashTable<T> extends StringHashTable<T> {
-              ~~~~~~~~~~~~~~~~~~~~~~
-!!! error TS2300: Duplicate identifier 'IdentiferNameHashTable'.
+        class IdentifierNameHashTable<T> extends StringHashTable<T> {
+              ~~~~~~~~~~~~~~~~~~~~~~~
+!!! error TS2300: Duplicate identifier 'IdentifierNameHashTable'.
             public getAllKeys(): string[];
             public add(key: string, data: T): boolean;
             public addOrUpdate(key: string, data: T): boolean;
@@ -81,9 +81,9 @@ tests/cases/compiler/genericClassesRedeclaration.ts(68,11): error TS2300: Duplic
             public lookup(key: string): T;
             public remove(key: string): void;
         }
-        class IdentiferNameHashTable<T> extends StringHashTable<T> {
-              ~~~~~~~~~~~~~~~~~~~~~~
-!!! error TS2300: Duplicate identifier 'IdentiferNameHashTable'.
+        class IdentifierNameHashTable<T> extends StringHashTable<T> {
+              ~~~~~~~~~~~~~~~~~~~~~~~
+!!! error TS2300: Duplicate identifier 'IdentifierNameHashTable'.
             public getAllKeys(): string[];
             public add(key: string, data: T): boolean;
             public addOrUpdate(key: string, data: T): boolean;
diff --git a/tests/baselines/reference/genericClassesRedeclaration.js b/tests/baselines/reference/genericClassesRedeclaration.js
@@ -27,7 +27,7 @@ declare module TypeScript {
         public lookup(key: string): T;
         public remove(key: string): void;
     }
-    class IdentiferNameHashTable<T> extends StringHashTable<T> {
+    class IdentifierNameHashTable<T> extends StringHashTable<T> {
         public getAllKeys(): string[];
         public add(key: string, data: T): boolean;
         public addOrUpdate(key: string, data: T): boolean;
@@ -66,7 +66,7 @@ declare module TypeScript {
         public lookup(key: string): T;
         public remove(key: string): void;
     }
-    class IdentiferNameHashTable<T> extends StringHashTable<T> {
+    class IdentifierNameHashTable<T> extends StringHashTable<T> {
         public getAllKeys(): string[];
         public add(key: string, data: T): boolean;
         public addOrUpdate(key: string, data: T): boolean;
diff --git a/tests/baselines/reference/genericClassesRedeclaration.symbols b/tests/baselines/reference/genericClassesRedeclaration.symbols
diff --git a/tests/baselines/reference/genericClassesRedeclaration.types b/tests/baselines/reference/genericClassesRedeclaration.types
diff --git a/tests/cases/compiler/genericClassesRedeclaration.ts b/tests/cases/compiler/genericClassesRedeclaration.ts
diff --git a/tests/cases/fourslash/completionListInvalidMemberNames.ts b/tests/cases/fourslash/completionListInvalidMemberNames.ts

Original file line number	Diff line number	Diff line change
`@@ -33615,7 +33615,7 @@ var ts;`
`33615`	`33615`	`return type;`
`33616`	`33616`	`}`
`33617`	`33617`	`// A reserved member name starts with two underscores, but the third character cannot be an underscore`
`33618`		`- // or the @ symbol. A third underscore indicates an escaped form of an identifer that started`
	`33618`	`+ // or the @ symbol. A third underscore indicates an escaped form of an identifier that started`
`33619`	`33619`	`// with at least two underscores. The @ character indicates that the name is denoted by a well known ES`
`33620`	`33620`	`// Symbol instance.`
`33621`	`33621`	`function isReservedMemberName(name) {`
Original file line number	Diff line number	Diff line change
`@@ -2843,7 +2843,7 @@ namespace ts {`
`2843`	`2843`	`}`
`2844`	`2844`
`2845`	`2845`	`// A reserved member name starts with two underscores, but the third character cannot be an underscore`
`2846`		`- // or the @ symbol. A third underscore indicates an escaped form of an identifer that started`
	`2846`	`+ // or the @ symbol. A third underscore indicates an escaped form of an identifier that started`
`2847`	`2847`	`// with at least two underscores. The @ character indicates that the name is denoted by a well known ES`
`2848`	`2848`	`// Symbol instance.`
`2849`	`2849`	`function isReservedMemberName(name: __String) {`