Skip to content

Commit a571e50

Browse files
committed
Use EmitAndSemanticDiagnosticsBuilder in builder from tsc
1 parent 2961bc3 commit a571e50

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

src/compiler/tsbuild.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -347,13 +347,13 @@ namespace ts {
347347
return host;
348348
}
349349

350-
export function createSolutionBuilderHost<T extends BuilderProgram = BuilderProgram>(system = sys, createProgram?: CreateProgram<T>, reportDiagnostic?: DiagnosticReporter, reportSolutionBuilderStatus?: DiagnosticReporter, reportErrorSummary?: ReportEmitErrorSummary) {
350+
export function createSolutionBuilderHost<T extends BuilderProgram = EmitAndSemanticDiagnosticsBuilderProgram>(system = sys, createProgram?: CreateProgram<T>, reportDiagnostic?: DiagnosticReporter, reportSolutionBuilderStatus?: DiagnosticReporter, reportErrorSummary?: ReportEmitErrorSummary) {
351351
const host = createSolutionBuilderHostBase(system, createProgram, reportDiagnostic, reportSolutionBuilderStatus) as SolutionBuilderHost<T>;
352352
host.reportErrorSummary = reportErrorSummary;
353353
return host;
354354
}
355355

356-
export function createSolutionBuilderWithWatchHost<T extends BuilderProgram = SemanticDiagnosticsBuilderProgram>(system = sys, createProgram?: CreateProgram<T>, reportDiagnostic?: DiagnosticReporter, reportSolutionBuilderStatus?: DiagnosticReporter, reportWatchStatus?: WatchStatusReporter) {
356+
export function createSolutionBuilderWithWatchHost<T extends BuilderProgram = EmitAndSemanticDiagnosticsBuilderProgram>(system = sys, createProgram?: CreateProgram<T>, reportDiagnostic?: DiagnosticReporter, reportSolutionBuilderStatus?: DiagnosticReporter, reportWatchStatus?: WatchStatusReporter) {
357357
const host = createSolutionBuilderHostBase(system, createProgram, reportDiagnostic, reportSolutionBuilderStatus) as SolutionBuilderWithWatchHost<T>;
358358
const watchHost = createWatchHost(system, reportWatchStatus);
359359
copyProperties(host, watchHost);

src/compiler/watch.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ namespace ts {
290290
/**
291291
* Creates the watch compiler host that can be extended with config file or root file names and options host
292292
*/
293-
export function createProgramHost<T extends BuilderProgram>(system: System, createProgram: CreateProgram<T> | undefined): ProgramHost<T> {
293+
export function createProgramHost<T extends BuilderProgram = EmitAndSemanticDiagnosticsBuilderProgram>(system: System, createProgram: CreateProgram<T> | undefined): ProgramHost<T> {
294294
const getDefaultLibLocation = memoize(() => getDirectoryPath(normalizePath(system.getExecutingFilePath())));
295295
let host: DirectoryStructureHost = system;
296296
host; // tslint:disable-line no-unused-expression (TODO: `host` is unused!)

src/tsc/tsc.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -207,9 +207,10 @@ namespace ts {
207207
reportWatchModeWithoutSysSupport();
208208
}
209209

210+
// Use default createProgram
210211
const buildHost = buildOptions.watch ?
211-
createSolutionBuilderWithWatchHost(sys, createEmitAndSemanticDiagnosticsBuilderProgram, reportDiagnostic, createBuilderStatusReporter(sys, shouldBePretty()), createWatchStatusReporter()) :
212-
createSolutionBuilderHost(sys, createAbstractBuilder, reportDiagnostic, createBuilderStatusReporter(sys, shouldBePretty()), createReportErrorSummary(buildOptions));
212+
createSolutionBuilderWithWatchHost(sys, /*createProgram*/ undefined, reportDiagnostic, createBuilderStatusReporter(sys, shouldBePretty()), createWatchStatusReporter()) :
213+
createSolutionBuilderHost(sys, /*createProgram*/ undefined, reportDiagnostic, createBuilderStatusReporter(sys, shouldBePretty()), createReportErrorSummary(buildOptions));
213214
updateCreateProgram(buildHost);
214215
buildHost.afterProgramEmitAndDiagnostics = (program: BuilderProgram) => reportStatistics(program.getProgram());
215216

0 commit comments

Comments
 (0)