forked from microsoft/TypeScript
-
Notifications
You must be signed in to change notification settings - Fork 1
/
Copy pathonly-arrow-functions.ts
91 lines (77 loc) · 2.95 KB
/
only-arrow-functions.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
import { AST_NODE_TYPES, TSESTree } from "@typescript-eslint/experimental-utils";
import { createRule } from "./utils";
type MessageId = "onlyArrowFunctionsError";
type Options = [{
allowNamedFunctions?: boolean;
allowDeclarations?: boolean;
}];
export = createRule<Options, MessageId>({
name: "only-arrow-functions",
meta: {
docs: {
description: `Disallows traditional (non-arrow) function expressions.`,
category: "Best Practices",
recommended: "error",
},
messages: {
onlyArrowFunctionsError: "non-arrow functions are forbidden",
},
schema: [{
additionalProperties: false,
properties: {
allowNamedFunctions: { type: "boolean" },
allowDeclarations: { type: "boolean" },
},
type: "object",
}],
type: "suggestion",
},
defaultOptions: [{
allowNamedFunctions: false,
allowDeclarations: false,
}],
create(context, [{ allowNamedFunctions, allowDeclarations }]) {
const isThisParameter = (node: TSESTree.FunctionDeclaration | TSESTree.FunctionExpression) => (
node.params.length && !!node.params.find(param => param.type === AST_NODE_TYPES.Identifier && param.name === "this")
);
const isMethodType = (node: TSESTree.Node) => {
const types = [
AST_NODE_TYPES.MethodDefinition,
AST_NODE_TYPES.Property,
];
const parent = node.parent;
if (!parent) {
return false;
}
return node.type === AST_NODE_TYPES.FunctionExpression && types.includes(parent.type);
};
const stack: boolean[] = [];
const enterFunction = () => {
stack.push(false);
};
const markThisUsed = () => {
if (stack.length) {
stack[stack.length - 1] = true;
}
};
const exitFunction = (node: TSESTree.FunctionDeclaration | TSESTree.FunctionExpression) => {
const methodUsesThis = stack.pop();
if (node.type === AST_NODE_TYPES.FunctionDeclaration && allowDeclarations) {
return;
}
if ((allowNamedFunctions && node.id !== null) || isMethodType(node)) { // eslint-disable-line no-null/no-null
return;
}
if (!(node.generator || methodUsesThis || isThisParameter(node))) {
context.report({ messageId: "onlyArrowFunctionsError", node });
}
};
return {
"FunctionDeclaration": enterFunction,
"FunctionDeclaration:exit": exitFunction,
"FunctionExpression": enterFunction,
"FunctionExpression:exit": exitFunction,
"ThisExpression": markThisUsed,
};
},
});