Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgres/postgres
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: amulsul/postgres
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 9 commits
  • 28 files changed
  • 1 contributor

Commits on Aug 7, 2025

  1. Refactor: pg_waldump: Move some declarations to new pg_waldump.h 

    This is in preparation for adding a second source file to this
directory.
    @amulsul
    amulsul committed Aug 7, 2025
    Configuration menu
    Copy the full SHA
    420ab4e View commit details
    Browse the repository at this point in the history

  2. Refactor: pg_waldump: Separate logic used to calculate the required r… 

    …ead size.

This refactoring prepares the codebase for an upcoming patch that will
support reading WAL from tar files. The logic for calculating the
required read size has been updated to handle both normal WAL files
and WAL files located inside a tar archive.
    @amulsul
    amulsul committed Aug 7, 2025
    Configuration menu
    Copy the full SHA
    30a226b View commit details
    Browse the repository at this point in the history

  3. Refactor: pg_waldump: Restructure TAP tests. 

    Restructured some tests to run inside a loop, facilitating their
re-execution for decoding WAL from tar archives.
    @amulsul
    amulsul committed Aug 7, 2025
    Configuration menu
    Copy the full SHA
    9e91214 View commit details
    Browse the repository at this point in the history

  4. pg_waldump: Rename directory creation routine for generalized use. 

    The create_fullpage_directory() function, currently used only for
storing full-page images from WAL records, should be renamed to a more
generalized name. This would allow it to be reused in future patches
for creating other directories as needed.
    @amulsul
    amulsul committed Aug 7, 2025
    Configuration menu
    Copy the full SHA
    5806291 View commit details
    Browse the repository at this point in the history

  5. pg_waldump: Add support for archived WAL decoding. 

    pg_waldump can now accept the path to a tar archive containing WAL
files and decode them. This feature was added primarily for
pg_verifybackup, which previously disabled WAL parsing for
tar-formatted backups.

Note that this patch requires that the WAL files within the archive be
in sequential order; an error will be reported otherwise. The next
patch is planned to remove this restriction.
    @amulsul
    amulsul committed Aug 7, 2025
    Configuration menu
    Copy the full SHA
    21d9d60 View commit details
    Browse the repository at this point in the history

  6. WIP-pg_waldump: Remove the restriction on the order of archived WAL f… 

    …iles.

With previous patch, pg_waldump would stop decoding if WAL files were
not in the required sequence. With this patch, decoding will now
continue.  Any WAL file that is out of order will be written to a
temporary location, from which it will be read later. Once a temporary
file has been read, it will be removed.

TODO:
  Timeline switching is not handled correctly, especially when a
  timeline change occurs on the next WAL file that was previously
  written to a temporary location.
    @amulsul
    amulsul committed Aug 7, 2025
    Configuration menu
    Copy the full SHA
    7469b7b View commit details
    Browse the repository at this point in the history

  7. pg_verifybackup: Delay default WAL directory preparation. 

    We are not sure whether to parse WAL from a directory or an archive
until the backup format is known. Therefore, we delay preparing the
default WAL directory until the point of parsing. This delay is
harmless, as the WAL directory is not used elsewhere.
    @amulsul
    amulsul committed Aug 7, 2025
    Configuration menu
    Copy the full SHA
    10816f5 View commit details
    Browse the repository at this point in the history

  8. pg_verifybackup: Rename the wal-directory switch to wal-path 

    Future patches to pg_waldump will enable it to decode WAL directly
from tar files. This means you'll be able to specify a tar archive
path instead of a traditional WAL directory.

To keep things consistent and more versatile, we should also
generalize the input switch for pg_verifybackup. It should accept
either a directory or a tar file path that contains WALs. This change
will also aligning it with the existing manifest-path switch naming.
    @amulsul
    amulsul committed Aug 7, 2025
    Configuration menu
    Copy the full SHA
    c8187d4 View commit details
    Browse the repository at this point in the history

  9. pg_verifybackup: enabled WAL parsing for tar-format backup 

    Now that pg_waldump supports decoding from tar archives, we should
leverage this functionality to remove the previous restriction on WAL
parsing for tar-backed formats.
    @amulsul
    amulsul committed Aug 7, 2025
    Configuration menu
    Copy the full SHA
    923a767 View commit details
    Browse the repository at this point in the history
Loading