Fixed an issue where trimming characters was perform after each

Antoine Marcadet · Antoine Marcadet · commit deb39a05fd7b · 2012-05-23T15:38:41.000+02:00
characters found and not after
diff --git a/XMLReader.m b/XMLReader.m
@@ -158,7 +158,9 @@ - (void)parser:(NSXMLParser *)parser didEndElement:(NSString *)elementName names
     // Set the text property
     if ([textInProgress length] > 0)
     {
-        [dictInProgress setObject:textInProgress forKey:kXMLReaderTextNodeKey];
+        // trim after concatenating
+        NSString *trimmedString = [textInProgress stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]];
+        [dictInProgress setObject:[[trimmedString mutableCopy] autorelease] forKey:kXMLReaderTextNodeKey];
 
         // Reset the text
         [textInProgress release];
@@ -172,7 +174,7 @@ - (void)parser:(NSXMLParser *)parser didEndElement:(NSString *)elementName names
 - (void)parser:(NSXMLParser *)parser foundCharacters:(NSString *)string
 {
     // Build the text value
-	[textInProgress appendString:[string stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]]];
+	[textInProgress appendString:string];
 }
 
 - (void)parser:(NSXMLParser *)parser parseErrorOccurred:(NSError *)parseError

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,9 @@ - (void)parser:(NSXMLParser )parser didEndElement:(NSString )elementName names`
`158`	`158`	`// Set the text property`
`159`	`159`	`if ([textInProgress length] > 0)`
`160`	`160`	`{`
`161`		`- [dictInProgress setObject:textInProgress forKey:kXMLReaderTextNodeKey];`
	`161`	`+ // trim after concatenating`
	`162`	`+ NSString *trimmedString = [textInProgress stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]];`
	`163`	`+ [dictInProgress setObject:[[trimmedString mutableCopy] autorelease] forKey:kXMLReaderTextNodeKey];`
`162`	`164`
`163`	`165`	`// Reset the text`
`164`	`166`	`[textInProgress release];`
`@@ -172,7 +174,7 @@ - (void)parser:(NSXMLParser )parser didEndElement:(NSString )elementName names`
`172`	`174`	`- (void)parser:(NSXMLParser )parser foundCharacters:(NSString )string`
`173`	`175`	`{`
`174`	`176`	`// Build the text value`
`175`		`- [textInProgress appendString:[string stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]]];`
	`177`	`+ [textInProgress appendString:string];`
`176`	`178`	`}`
`177`	`179`
`178`	`180`	`- (void)parser:(NSXMLParser )parser parseErrorOccurred:(NSError )parseError`