Skip to content

Commit 0340b39

Browse files
committed
Fixed PMD issues
1 parent c5510fb commit 0340b39

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

src/com/magento/idea/magento2plugin/actions/generation/dialog/NewModelsDialog.java

+9-9
Original file line numberDiff line numberDiff line change
@@ -223,11 +223,11 @@ private void onOK() {
223223
private PsiFile generateModelFile() {
224224
final NamespaceBuilder modelNamespace = getModelNamespace();
225225
final NamespaceBuilder resourceModelNamespace = getResourceModelNamespace();
226-
String resourceModelFqn = resourceModelNamespace.getClassFqn();
226+
StringBuilder resourceModelFqn = new StringBuilder(resourceModelNamespace.getClassFqn());
227227
String resorceModelName = getResourceModelName();
228228

229229
if (getModelName().equals(getResourceModelName())) {
230-
resourceModelFqn += " as ResourceModel";
230+
resourceModelFqn.append(" as ResourceModel");
231231
resorceModelName = "ResourceModel";
232232
}
233233

@@ -238,7 +238,7 @@ private PsiFile generateModelFile() {
238238
resorceModelName,
239239
modelNamespace.getClassFqn(),
240240
modelNamespace.getNamespace(),
241-
resourceModelFqn
241+
resourceModelFqn.toString()
242242
), project).generate(NewModelsDialog.ACTION_NAME, true);
243243
}
244244

@@ -258,16 +258,16 @@ private PsiFile generateCollectionFile() {
258258
final NamespaceBuilder resourceModelNamespace = getResourceModelNamespace();
259259
final NamespaceBuilder modelNamespace = getModelNamespace();
260260
final NamespaceBuilder collectionNamespace = getCollectionNamespace();
261-
String modelFqn = modelNamespace.getClassFqn();
261+
StringBuilder modelFqn = new StringBuilder(modelNamespace.getClassFqn());
262262
String modelName = getModelName();
263-
String resourceModelFqn = resourceModelNamespace.getClassFqn();
263+
StringBuilder resourceModelFqn = new StringBuilder(resourceModelNamespace.getClassFqn());
264264
String resorceModelName = getResourceModelName();
265265

266266

267267
if (getModelName().equals(getResourceModelName())) {
268-
modelFqn += " as Model";
268+
modelFqn.append(" as Model");
269269
modelName = "Model";
270-
resourceModelFqn += " as ResourceModel";
270+
resourceModelFqn.append(" as ResourceModel");
271271
resorceModelName = "ResourceModel";
272272
}
273273

@@ -280,8 +280,8 @@ private PsiFile generateCollectionFile() {
280280
getCollectionDirectory(),
281281
collectionNamespace.getNamespace(),
282282
resorceModelName,
283-
resourceModelFqn,
284-
modelFqn
283+
resourceModelFqn.toString(),
284+
modelFqn.toString()
285285
), project).generate(NewModelsDialog.ACTION_NAME, true);
286286
}
287287

0 commit comments

Comments
 (0)