add eslint

Description:
- add eslint-related packages, npm script and configs
author used to
- fix eslint issues

Author: akuzko

.eslintrc

@@ -0,0 +1,36 @@
+{
+  'env': {
+    'browser': true,
+    'mocha': true,
+    'node': true
+  },
+  'plugins': ['react'],
+  'parser': 'babel-eslint',
+  'rules': {
+    'quotes': [1, 'single', 'avoid-escape'],
+    'semi': [1, 'always'],
+    'no-undef': 2,
+    'no-unused-vars': 2,
+    'no-underscore-dangle': 0,
+    'no-use-before-define': 0,
+    'jsx-quotes': [1, 'prefer-double'],
+    'prefer-const': 2,
+    'comma-dangle': [2, 'never'],
+
+    'react/jsx-first-prop-new-line': [2, 'multiline'],
+    'react/prefer-stateless-function': 0,
+    'react/jsx-space-before-closing': [2, 'always'],
+    'react/prefer-es6-class': 0,
+    'react/prop-types': 2,
+    'react/self-closing-comp': 2,
+    'react/jsx-no-undef': 1,
+    'react/jsx-uses-react': 1,
+    'react/jsx-uses-vars': 1,
+    'react/jsx-boolean-value': [2, 'never'],
+    'react/jsx-closing-bracket-location': [2, 'tag-aligned'],
+    'react/jsx-equals-spacing': [1, 'never'],
+    'react/jsx-indent-props': [1, 2],
+    'react/jsx-indent': [1, 2],
+    'react/jsx-no-duplicate-props': 2,
+  }
+}

package.json

@@ -8,7 +8,8 @@
     "clear": "rimraf lib",
     "rebuild": "npm run clear && npm run build",
     "test": "mocha --compilers js:babel-register --recursive --require ./test/setup.js",
-    "test:watch": "npm test -- --watch"
+    "test:watch": "npm test -- --watch",
+    "lint": "eslint src test"
   },
   "repository": {
     "type": "git",
@@ -30,10 +31,13 @@
   "devDependencies": {
     "babel-cli": "^6.16.0",
     "babel-core": "^6.16.0",
+    "babel-eslint": "^7.0.0",
     "babel-preset-es2015": "^6.16.0",
     "babel-preset-react": "^6.16.0",
     "babel-preset-stage-1": "^6.16.0",
     "enzyme": "^2.4.1",
+    "eslint": "^3.7.0",
+    "eslint-plugin-react": "^6.3.0",
     "expect": "^1.20.2",
     "jsdom": "^9.5.0",
     "mocha": "^3.1.0",

test/components/Connection.test.js

@@ -7,21 +7,21 @@ import expect from 'expect';
 describe('<Connection />', function() {
   class TestConnection extends Connection {
     load() {
-      return this.$load([1, 2, 3])
+      return this.$load([1, 2, 3]);
     }
     render() {
-      return <div className="connection" onClick={() => this.load()} />
+      return <div className="connection" onClick={() => this.load()} />;
     }
   }
 
   class TestConnector extends Connector {
     static $connection = TestConnection;
     static $state = []
-    static $reducer = TestConnector.reduce('foo', (state) => ({
+    static $reducer = TestConnector.reduce('foo', () => ({
       $receive: (items) => items
     }));
-    $expose($state) { return { items: $state } }
-    $load(items) { return this.$$receive(items) }
+    $expose($state) { return { items: $state }; }
+    $load(items) { return this.$$receive(items); }
   }
 
   it('has event-handler methods (that start with $) provided by Connector', function() {

test/components/Connector.test.js

@@ -1,9 +1,9 @@
-import React from 'react';
+import React, { PropTypes } from 'react';
 import { createStore } from 'redux';
 import { Connector } from '../../src';
 import storeShape from '../../src/utils/storeShape';
 import { shallow, mount } from 'enzyme';
-import expect, { createSpy, spyOn } from 'expect';
+import expect, { spyOn } from 'expect';
 
 describe('Connector', function() {
   describe('.reduce', function() {
@@ -62,12 +62,13 @@ describe('Connector', function() {
 describe('<Connector />', function() {
   const store = createStore(state => state);
   const Provider = React.createClass({
+    propTypes: { children: PropTypes.node },
     childContextTypes: { store: storeShape },
-    getChildContext() { return { store } },
-    render() { return this.props.children }
+    getChildContext() { return { store }; },
+    render() { return this.props.children; }
   });
   class Connection extends React.Component {
-    render() { return <div className="connection" /> }
+    render() { return <div className="connection" />; }
   }
 
   describe('initialization', function() {
@@ -76,7 +77,7 @@ describe('<Connector />', function() {
     }
 
     it('throws an error if store is undefined', function() {
-      expect(function(){ shallow(<TestConnector />) })
+      expect(function(){ shallow(<TestConnector />); })
         .toThrow('TestConnector instance expects store object in props or in context');
     });
 
@@ -87,7 +88,7 @@ describe('<Connector />', function() {
 
     it('accepts store from context', function() {
       let instance = null;
-      const wrapper = mount(<Provider><TestConnector ref={(inst) => instance = inst} /></Provider>);
+      mount(<Provider><TestConnector ref={(inst) => instance = inst} /></Provider>);
       expect(instance.store).toBe(store);
     });
   });
@@ -193,12 +194,12 @@ describe('<Connector />', function() {
       class TestConnector extends Connector {
         static $connection = Connection;
         static $state = [];
-        static $reducer = TestConnector.reduce('foo', (state) => ({}));
+        static $reducer = TestConnector.reduce('foo', () => ({}));
       }
 
       it('throws an error', function() {
         const store = createStore(TestConnector.$reducer);
-        expect(function() { mount(<TestConnector store={store} />) })
+        expect(function() { mount(<TestConnector store={store} />); })
           .toThrow('TestConnector.$state should be a plain object' +
             'or there should be a $expose instance method defined that returns a plain object'
           );
@@ -209,13 +210,13 @@ describe('<Connector />', function() {
       class TestConnector extends Connector {
         static $connection = Connection;
         static $state = { items: [] };
-        static $reducer = TestConnector.reduce('foo', (state) => ({}));
-        $expose($state) { return $state.items }
+        static $reducer = TestConnector.reduce('foo', () => ({}));
+        $expose($state) { return $state.items; }
       }
 
       it('throws an error', function() {
         const store = createStore(TestConnector.$reducer);
-        expect(function() { mount(<TestConnector store={store} />) })
+        expect(function() { mount(<TestConnector store={store} />); })
           .toThrow('TestConnector.$state should be a plain object' +
             'or there should be a $expose instance method defined that returns a plain object'
           );
@@ -310,7 +311,7 @@ describe('<Connector />', function() {
     it('throws an error when no connection is specified', function() {
       class BadConnector extends Connector {}
 
-      expect(function(){ mount(<BadConnector store={store} />) })
+      expect(function(){ mount(<BadConnector store={store} />); })
         .toThrow('BadConnector should define a $connection class property');
     });