Merge pull request #55 from AgileBits/improvement/parameter-validation

[IMPROVEMENT] We now make sure that all parameneters are non nil.

Author: roustem

OnePasswordExtension.m

@@ -78,6 +78,9 @@ - (BOOL)isAppExtensionAvailable {
 
 - (void)findLoginForURLString:(NSString *)URLString forViewController:(UIViewController *)viewController completion:(void (^)(NSDictionary *loginDictionary, NSError *error))completion
 {
+	NSAssert(URLString != nil, @"URLString must not be nil");
+	NSAssert(viewController != nil, @"viewController must not be nil");
+
 	if (![self isSystemAppExtensionAPIAvailable]) {
 		NSLog(@"Failed to findLoginForURLString, system API is not available");
 		if (completion) {
@@ -125,6 +128,10 @@ - (void)findLoginForURLString:(NSString *)URLString forViewController:(UIViewCon
 
 - (void)storeLoginForURLString:(NSString *)URLString loginDetails:(NSDictionary *)loginDetailsDict passwordGenerationOptions:(NSDictionary *)passwordGenerationOptions forViewController:(UIViewController *)viewController completion:(void (^)(NSDictionary *loginDictionary, NSError *error))completion;
 {
+	NSAssert(URLString != nil, @"URLString must not be nil");
+	NSAssert(loginDetailsDict != nil, @"loginDetailsDict must not be nil");
+	NSAssert(viewController != nil, @"viewController must not be nil");
+
 	if (![self isSystemAppExtensionAPIAvailable]) {
 		NSLog(@"Failed to storeLoginForURLString, system API is not available");
 		if (completion) {
@@ -178,6 +185,10 @@ - (void)storeLoginForURLString:(NSString *)URLString loginDetails:(NSDictionary
 
 - (void)changePasswordForLoginWithUsername:(NSString *)username andURLString:(NSString *)URLString passwordGenerationOptions:(NSDictionary *)passwordGenerationOptions forViewController:(UIViewController *)viewController completion:(void (^)(NSDictionary *loginDict, NSError *error))completion
 {
+	NSAssert(username != nil, @"username must not be nil");
+	NSAssert(URLString != nil, @"URLString must not be nil");
+	NSAssert(viewController != nil, @"viewController must not be nil");
+
 	if (![self isSystemAppExtensionAPIAvailable]) {
 		NSLog(@"Failed to changePasswordForLoginWithUsername, system API is not available");
 		if (completion) {
@@ -230,6 +241,9 @@ - (void)changePasswordForLoginWithUsername:(NSString *)username andURLString:(NS
 
 - (void)fillLoginIntoWebView:(id)webView forViewController:(UIViewController *)viewController completion:(void (^)(BOOL success, NSError *error))completion
 {
+	NSAssert(webView != nil, @"webView must not be nil");
+	NSAssert(viewController != nil, @"viewController must not be nil");
+
 #ifdef __IPHONE_8_0
 	if ([webView isKindOfClass:[UIWebView class]]) {
 		[self fillLoginIntoUIWebView:webView webViewController:viewController completion:^(BOOL success, NSError *error) {