added raycaster test

Author: ngokevin

docs/components/raycaster.md

@@ -50,19 +50,19 @@ AFRAME.registerComponent('collider-check', {
 
 ## Properties
 
-| Property            | Description                                                                                                                                                        | Default Value |
-| --------            | -----------                                                                                                                                                        | ------------- |
-| autoRefresh         | Whether to automatically refresh raycaster's list of objects to test for intersection using mutation observers to detect added or removed entities and components. | true          |
-| direction           | Vector3 coordinate of which direction the ray should point from relative to the entity's origin.                                                                   | 0, 0, -1       |
-| enabled             | Whether raycaster is actively checking for intersections.                                                                                                          | true          |
-| far                 | Maximum distance under which resulting entities are returned. Cannot be lower than `near`.                                                                         | Infinity      |
-| interval            | Number of milliseconds to wait in between each intersection test. Lower number is better for faster updates. Higher number is better for performance. Intersection tests are performed at most once per frame.             | 0           |
-| near                | Minimum distance over which resuilting entities are returned. Cannot be lower than 0.                                                                              | 0             |
-| objects             | Query selector to pick which objects to test for intersection. If not specified, all entities will be tested.                                                      | null          |
-| origin              | Vector3 coordinate of where the ray should originate from relative to the entity's origin.                                                                         | 0, 0, 0       |
-| recursive           | Checks all children of objects if set. Else only checks intersections with root objects.                                                                           | true          |
-| showLine            | Whether or not to display the raycaster visually with the [line component][line].                                                                                  | false         |
-| useWorldCoordinates | Whether the raycaster origin and direction properties are specified in world coordinates.                                                                          | false         |
+| Property            | Description                                                                                                                                                                                                    | Default Value |
+| --------            | -----------                                                                                                                                                                                                    | ------------- |
+| autoRefresh         | Whether to automatically refresh raycaster's list of objects to test for intersection using mutation observers to detect added or removed entities and components.                                             | true          |
+| direction           | Vector3 coordinate of which direction the ray should point from relative to the entity's origin.                                                                                                               | 0, 0, -1      |
+| enabled             | Whether raycaster is actively checking for intersections.                                                                                                                                                      | true          |
+| far                 | Maximum distance under which resulting entities are returned. Cannot be lower than `near`.                                                                                                                     | Infinity      |
+| interval            | Number of milliseconds to wait in between each intersection test. Lower number is better for faster updates. Higher number is better for performance. Intersection tests are performed at most once per frame. | 0             |
+| near                | Minimum distance over which resuilting entities are returned. Cannot be lower than 0.                                                                                                                          | 0             |
+| objects             | Query selector to pick which objects to test for intersection. If not specified, all entities will be tested. Note that only objects attached via `.setObject3D` will be tested.                               | null          |
+| origin              | Vector3 coordinate of where the ray should originate from relative to the entity's origin.                                                                                                                     | 0, 0, 0       |
+| recursive           | Checks children of objects if set. Else only checks intersections with root objects. Note that only objects attached via `setObject3D` are tested.                                                             | true          |
+| showLine            | Whether or not to display the raycaster visually with the [line component][line].                                                                                                                              | false         |
+| useWorldCoordinates | Whether the raycaster origin and direction properties are specified in world coordinates.                                                                                                                      | false         |
 
 ## Events
 

src/components/raycaster.js

@@ -388,7 +388,7 @@ module.exports.Component = registerComponent('raycaster', {
    * so that non-recursive raycasting remains useful.
    *
    * Only push children defined as component attachemnts (e.g., setObject3D),
-   * not actual children in the scene graph hierarchy.
+   * NOT actual children in the scene graph hierarchy.
    *
    * @param  {Array<Element>} els
    * @return {Array<THREE.Object3D>}

tests/components/raycaster.test.js

@@ -82,6 +82,26 @@ suite('raycaster', function () {
       sceneEl.appendChild(el2);
     });
 
+    test('cannot have redundant objects', function (done) {
+      const el1 = document.createElement('a-entity');
+      el1.setAttribute('geometry', 'primitive: box');
+      const el2 = document.createElement('a-entity');
+      el2.setAttribute('geometry', 'primitive: box');
+      el1.appendChild(el2);
+
+      el1.addEventListener('loaded', function () {
+        component.refreshObjects();
+        const mesh = el2.getObject3D('mesh');
+        let count = 0;
+        component.objects.forEach(obj => {
+          if (obj === mesh) { count++; }
+        });
+        assert.equal(count, 1);
+        done();
+      });
+      sceneEl.appendChild(el1);
+    });
+
     test('can whitelist objects to intersect', function (done) {
       var el2 = document.createElement('a-entity');
       var el3 = document.createElement('a-entity');