code-standard-less.md

group	subgroup	title	landing-page	menu_title	menu_order	functional_areas
coding-standards	01_Coding standards	Less coding standard	Coding standards	Less coding standard	8	Standards

This standard defines Magento internal requirements for code formatting and style for teams that develop Less and CSS code.

Some parts of Magento code might not comply with this coding standard yet, but we are working to gradually improve this.

This coding standard is optional for third-party Magento developers.

General rules

Indentation

Use only spaces for indentation:

• Tab size: 4 spaces
• Indent size: 4 spaces
• Continuation indent: 4 spaces

Correct:

.nav {
    .nav-item {
        ...
    }
}

Formatting

Braces

Add one space before opening braces and a line break after. Add a line break before closing braces.

Correct:

.nav {
    color: @nav__color;
}

Incorrect:

.nav{color: @nav__color;}

Selector delimiters

Add a line break after each selector delimiter. Do not add spaces before or after delimiters.

Correct:

.nav,
.bar {
    color: @color__base;
}

Incorrect:

.nav, .bar {
    color: @color__base;
}

Quotes

Use single quotes.

Correct:

.nav {
    content: 'lorem ipsum';
}

Incorrect:

.nav {
    content: "lorem ipsum";
}

Combinator indents

Add spaces before and after combinators.

Correct:

.nav + .bar {
    color: @bar__color;
}

Incorrect:

.nav+.bar {
    color: @bar__color;
}

.nav +.bar {
    color: @bar__color;
}

.nav+ .bar {
    color: @bar__color;
}

Properties line break

Start each property declaration in a new line.

Correct:

.nav {
    background-color: @nav__background-color;
    color: @nav__color;
}

Incorrect:

.nav {
    color: @nav__color; background-color: @nav__background-color;
}

Properties colon indents

Add space after but not before the colon that separates property names from values.

Correct:

.nav {
    color: @nav__color;
}

Incorrect:

.nav {
    color : @nav__color;
}

.bar {
    color:@bar__color;
}

.item {
    color :@item__color;
}

End of file

Add a blank line at the end of file.

End of selector

Add a blank line after a selector.

Correct:

.nav {
    background-color: @nav__background-color;
}

.bar {
    background-color: @bar__background-color;
}

Incorrect:

.nav {
    background-color: @nav__background-color;
}
.bar {
    background-color: @bar__background-color;
}

End of the property line

Add a semicolon after property.

Correct:

.nav {
    background-color: @nav__background-color;
}

Incorrect:

.nav {
    background-color: @nav__background-color
}

!important property

Avoid using the !important property if possible. If it is required, add a space before the property.

Correct

.jquery-ui-calendar-item {
    background-color: @nav__background-color !important;
}

Incorrect:

.jquery-ui-calendar-item {
    background-color: @nav__background-color!important;
}

Comments

First and second level comments must be surrounded by empty lines. First, second and third level comments should have two spaces after "//". Inline comments should have one space after "//".

Correct

//
//  First level comment
//  _____________________________________________

.nav {
    background-color: @nav__background-color;
}

//
//  Second level comment
//  ---------------------------------------------

.nav {
    background-color: @nav__background-color;
}

//  Comment
.nav {
    //  New line comment
    background-color: @nav__background-color; // ToDo UI: todo inline comment
    color: @nav__color; // inline comment
}

Selectors

Types

Magento supports the two most recent versions of all major browsers. Internet Explorer is supported from version 9 and later.

You can use almost all CSS3 selectors: descendants, attributes, pseudo classes, structural, pseudo elements, and so on.

Exception: Avoid the id selector.

Correct:

.nav {
    ...
}

.nav + bar {
    ...
}

.nav:not(.bar) {
    ...
}

Incorrect:

#foo {
    ...
}

Classes Naming

Standard classes

Class names should be lowercase, start with a letter (except helper classes), words should be separated with dash '-'.

Correct:

.nav-bar {
    ...
}

Incorrect:

.navBar {
    ...
}

Incorrect: underscore separation

.nav_bar {
    ...
}

Helper classes

Helper class names should be lowercase and start with underscore ("_").

Some parts of Magento code might not comply with this standard yet. You might still find helper names with no underscores. We are working to gradually remove the inconsistency.

Example:

._active {
    ...
}

Size

Use class names that are as short as possible, but as long as necessary. Try to convey what class is about while being as brief as possible.

Correct:

.nav-bar {
    ...
}

Incorrect: too long

.navigation-panel-in-footer {
    ...
}

Incorrect: too short

.nvpf {
    ...
}

Meaning

Use meaningful, specific class names that reflect the purpose of the element. Class names should not be presentational or cryptic.

Correct: specific

.category {
    ...
}
.category-title {
    ...
}

Incorrect: cryptic

.foo-1901 {
    ...
}

Incorrect: presentational

.button-green {
    ...
}

.clear {
    ...
}

Selectors naming

Type selectors

Avoid qualifying class names with type selectors.

Unless necessary (for example with helper classes), do not use element names in conjunction with IDs or classes.

Correct:

.error {
    ...
}

Incorrect:

div.error {
    ...
}

Type selectors must be lowercase.

Correct:

.nav > li {
    ...
}

Incorrect:

.nav > LI {
    ...
}

Formatting

Write selector in one line, do not use concatenation.

Correct:

.product-list-item {
    ...
}

Incorrect:

.product {
    ...
    &-list {
        ...
        &-item {
            ...
        }
    }
}

Nesting

Avoid using more than three levels of nesting.

Exceptions are pseudo elements and states.

Correct:

.footer {
    ...
    .nav {
        ...
    }
    .nav-list {
        ...
        .nav-list-item {
            ...
        }
    }
}

Incorrect:

.footer {
    ...
    .nav {
        ...
        .nav-list {
            ...
            .nav-list-item {
                ...
            }
        }
    }
}

Properties

Sorting

Sort all properties in the alphabetical order. Mixins, variables, and so on should go first.

Correct:

.nav {
    background-color: @nav__background-color;
    color: @nav__color;
    text-align: center;
}

Incorrect:

.nav {
    color: @nav__color;
    text-align: center;
    background-color: @nav__background-color;
}

Shorthand

Use shorthand properties where possible.

CSS offers a variety of shorthand properties that should be used whenever possible, even in cases where only one value is explicitly set.

Correct:

border-top: 0;
padding: 0 1em 2em;

Incorrect:

border-top-style: none;
padding-bottom: 2rem;
padding-left: 1rem;
padding-right: 1rem;
padding-top: 0;

0 and units

Do not specify units "0" value.

Correct:

border-width: 0;
margin: 0;

Incorrect:

border-width: 0px;
margin: 0rem;

Floating values

Omit leading "0"s in values, use dot instead.

Correct:

margin-left: .5rem;

Incorrect:

margin-left: 0.5rem;

Hexadecimal notation

• Use lowercase only.
• Use three-character hexadecimal notation where possible.
• Avoid using hexadecimal values for color in properties, use only variables instead.

Correct:

@nav__color: #fafafa;
@nav-item__color: #f00;
...
color: @nav-item__color;

Incorrect:

color: #ff0000;
@nav__color: #FAFAFA;
@nav-item__color: red;

Variables

Location

Local variables

If variables are local and used only in a module scope, they should be located in the module file, in the beginning of the general comment.

Example _module.less:

...

//
//  Variables
//  _____________________________________________

    //  Colors
@btn__color: @color-brownie;
@btn-primary__color: @color-white;
@btn-secondary__color: @color-white;
...

Theme variables

If variables are common for several modules they should be specified in the _theme.less file

Naming

All variable names must be lowercase.

Value variables

General model is the following:

@property-name

Examples:

@primary__color: @color-phoenix;
@indent__base: 2rem;
@border-radius-round: 100%;

Parameter variables

General model is the following:

@component-element__state__property__modifier

Component name must meaningful. It can contain the primary, secondary, tertiary names.

base is a modifier.

Examples:

@color-orange: '';

@link__hover__color: '';

@nav-element__background-color: '';

@secondary__color: '';

@side-nav__indent__s: '';

@side-nav-el__background-color: '';

@side-nav-el__active__background-color: '';

@side-nav-el__active-focus__background-color: '';

@side-nav-el__active-focus__font-size__xl: '';

@text__color__base: '';

Mixins

Location

Theme mixins (except extends) should be located in the source/utilities directory.

Naming

For mixin naming apply the class naming rules.

For mixins grouping use the double underscore "__" prefix.

Example:

.extend__clearfix (...) {
    ...
}

.vendor-prefix__flex-direction (...) {
    ...
}

Extends

Location

Local extends used only in one file, should be specified in this file. Extends that are used in several files should be specified in the theme's source/_extend.less file.

Naming

Extend names should start with the .abs- prefix.

@import directive

Always add the file extension of the imported resource.

Correct:

@import 'source/lib/_lib.less';
@import (css) 'styles.css';

Incorrect:

@import 'source/lib/_lib';
@import (css) 'styles';

Use single quotes.

Correct:

@import 'source/lib/_lib.less';

Incorrect:

@import "source/lib/_lib.less";