Skip to content

Commit 9130f8c

Browse files
committed
Fix breakage in AlterFunction().
An ALTER FUNCTION command that tried to update both the function's proparallel property and its proconfig list failed to do the former, because it stored the new proparallel value into a tuple that was no longer the interesting one. Carelessness in 7aea8e4. (I did not bother with a regression test, because the only likely future breakage would be for someone to ignore the comment I added and add some other field update after the heap_modify_tuple step. A test using existing function properties could not catch that.) Per report from Bryn Llewellyn. Back-patch to all supported branches. Discussion: https://postgr.es/m/8AC9A37F-99BD-446F-A2F7-B89AD0022774@yugabyte.com
1 parent a90de82 commit 9130f8c

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/backend/commands/functioncmds.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1269,6 +1269,8 @@ AlterFunction(ParseState *pstate, AlterFunctionStmt *stmt)
12691269
(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
12701270
errmsg("ROWS is not applicable when function does not return a set")));
12711271
}
1272+
if (parallel_item)
1273+
procForm->proparallel = interpret_func_parallel(parallel_item);
12721274
if (set_items)
12731275
{
12741276
Datum datum;
@@ -1303,8 +1305,7 @@ AlterFunction(ParseState *pstate, AlterFunctionStmt *stmt)
13031305
tup = heap_modify_tuple(tup, RelationGetDescr(rel),
13041306
repl_val, repl_null, repl_repl);
13051307
}
1306-
if (parallel_item)
1307-
procForm->proparallel = interpret_func_parallel(parallel_item);
1308+
/* DO NOT put more touches of procForm below here; it's now dangling. */
13081309

13091310
/* Do the update */
13101311
CatalogTupleUpdate(rel, &tup->t_self, tup);

0 commit comments

Comments
 (0)