Skip to content

Commit 409bcfd

Browse files
committed
Fix breakage in AlterFunction().
An ALTER FUNCTION command that tried to update both the function's proparallel property and its proconfig list failed to do the former, because it stored the new proparallel value into a tuple that was no longer the interesting one. Carelessness in 7aea8e4. (I did not bother with a regression test, because the only likely future breakage would be for someone to ignore the comment I added and add some other field update after the heap_modify_tuple step. A test using existing function properties could not catch that.) Per report from Bryn Llewellyn. Back-patch to all supported branches. Discussion: https://postgr.es/m/8AC9A37F-99BD-446F-A2F7-B89AD0022774@yugabyte.com
1 parent be46985 commit 409bcfd

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/backend/commands/functioncmds.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1253,6 +1253,8 @@ AlterFunction(ParseState *pstate, AlterFunctionStmt *stmt)
12531253
(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
12541254
errmsg("ROWS is not applicable when function does not return a set")));
12551255
}
1256+
if (parallel_item)
1257+
procForm->proparallel = interpret_func_parallel(parallel_item);
12561258
if (set_items)
12571259
{
12581260
Datum datum;
@@ -1287,8 +1289,7 @@ AlterFunction(ParseState *pstate, AlterFunctionStmt *stmt)
12871289
tup = heap_modify_tuple(tup, RelationGetDescr(rel),
12881290
repl_val, repl_null, repl_repl);
12891291
}
1290-
if (parallel_item)
1291-
procForm->proparallel = interpret_func_parallel(parallel_item);
1292+
/* DO NOT put more touches of procForm below here; it's now dangling. */
12921293

12931294
/* Do the update */
12941295
CatalogTupleUpdate(rel, &tup->t_self, tup);

0 commit comments

Comments
 (0)