use CYW43_DEFAULT_PIN_WL_CLOCK when checking for CYW43 shared GPIO29 use

Author: dhalbert

ports/raspberrypi/common-hal/analogbufio/BufferedIn.c

@@ -20,11 +20,14 @@
 
 void common_hal_analogbufio_bufferedin_construct(analogbufio_bufferedin_obj_t *self, const mcu_pin_obj_t *pin, uint32_t sample_rate) {
     // Make sure pin number is in range for ADC
-    if ((pin->number < ADC_BASE_PIN) ||
-        (pin->number > ADC_BASE_PIN + NUM_ADC_CHANNELS - 1) ||
-        // On Pico W and Pico 2 W, GPIO29 is both a voltage monitor and used for SPI to the CYW43.
+    if ((pin->number < ADC_BASE_PIN)
+        || (pin->number > ADC_BASE_PIN + NUM_ADC_CHANNELS - 1)
+        // On many boards with a CYW43 radio co-processor, CYW43_DEFAULT_PIN_WL_CLOCK (usually GPIO29),
+        // is both a voltage monitor and also SPI SCK to the CYW43.
         // Disallow its use for BufferedIn.
-        (CIRCUITPY_CYW43 && pin->number == 29)
+        #if defined(CIRCUITPY_CYW43) && defined(CYW43_DEFAULT_PIN_WL_CLOCK)
+        || (pin->number == CYW43_DEFAULT_PIN_WL_CLOCK)
+        #endif
         ) {
         raise_ValueError_invalid_pin();
     }

ports/raspberrypi/common-hal/analogio/AnalogIn.c

@@ -12,12 +12,12 @@
 
 #include "hardware/adc.h"
 
-// Voltage monitor is special on Pico W and Pico 2 W, because this pin is shared between the
-// voltage monitor function and the wifi function. Special handling is required
-// to read the analog voltage.
+// On many boards with a CYW43 radio co-processor, CYW43_DEFAULT_PIN_WL_CLOCK (usually GPIO29),
+// is both a voltage monitor and also SPI SCK to the CYW43.
+// Special handling is required to read the analog voltage.
 #if CIRCUITPY_CYW43
 #include "bindings/cyw43/__init__.h"
-#define SPECIAL_PIN(pin) (pin->number == 29)
+#define SPECIAL_PIN(pin) (pin->number == CYW43_DEFAULT_PIN_WL_CLOCK)
 
 const mcu_pin_obj_t *common_hal_analogio_analogin_validate_pin(mp_obj_t obj) {
     return validate_obj_is_free_pin_or_gpio29(obj, MP_QSTR_pin);

shared-bindings/analogbufio/BufferedIn.c

@@ -39,11 +39,12 @@
 //|     def __init__(self, pin: microcontroller.Pin, *, sample_rate: int) -> None:
 //|         """Create a `BufferedIn` on the given pin and given sample rate.
 //|
-//|         **Limitations**: On Pi Pico W and Pi Pico 2 W, pin ``board.A3`` is not supported
-//|         because it is also used to control the CYW43 radio module.
-//|
 //|         :param ~microcontroller.Pin pin: the pin to read from
 //|         :param ~int sample_rate: rate: sampling frequency, in samples per second"""
+//|
+//|         **Limitations**: On many boards with a CYW43 radio module, such as Pico W,
+//|         GPIO29 (often ``board.A3``) is also used to control the CYW43,
+// }         and is therefore not available to use as the `BufferedIn` pin.
 //|         ...
 //|
 static mp_obj_t analogbufio_bufferedin_make_new(const mp_obj_type_t *type, size_t n_args, size_t n_kw, const mp_obj_t *all_args) {