I2C SDA should properly register the ACK bit from some slaves

me-no-dev · me-no-dev · commit f3af437774e3 · 2016-10-10T13:53:55.000+03:00
diff --git a/cores/esp32/esp32-hal-i2c.c b/cores/esp32/esp32-hal-i2c.c
@@ -26,7 +26,7 @@
 
 void i2cAttachSCL(i2c_t * i2c, int8_t scl)
 {
-    pinMode(scl, INPUT);
+    pinMode(scl, OUTPUT_OPEN_DRAIN);
     pinMatrixOutAttach(scl, I2C_SCL_IDX(i2c->num), false, false);
     pinMatrixInAttach(scl, I2C_SCL_IDX(i2c->num), false);
 }
@@ -40,7 +40,7 @@ void i2cDetachSCL(i2c_t * i2c, int8_t scl)
 
 void i2cAttachSDA(i2c_t * i2c, int8_t sda)
 {
-    pinMode(sda, INPUT);
+    pinMode(sda, OUTPUT_OPEN_DRAIN);
     pinMatrixOutAttach(sda, I2C_SDA_IDX(i2c->num), false, false);
     pinMatrixInAttach(sda, I2C_SDA_IDX(i2c->num), false);
 }

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@`
`26`	`26`
`27`	`27`	`void i2cAttachSCL(i2c_t * i2c, int8_t scl)`
`28`	`28`	`{`
`29`		`- pinMode(scl, INPUT);`
	`29`	`+ pinMode(scl, OUTPUT_OPEN_DRAIN);`
`30`	`30`	`pinMatrixOutAttach(scl, I2C_SCL_IDX(i2c->num), false, false);`
`31`	`31`	`pinMatrixInAttach(scl, I2C_SCL_IDX(i2c->num), false);`
`32`	`32`	`}`
`@@ -40,7 +40,7 @@ void i2cDetachSCL(i2c_t * i2c, int8_t scl)`
`40`	`40`
`41`	`41`	`void i2cAttachSDA(i2c_t * i2c, int8_t sda)`
`42`	`42`	`{`
`43`		`- pinMode(sda, INPUT);`
	`43`	`+ pinMode(sda, OUTPUT_OPEN_DRAIN);`
`44`	`44`	`pinMatrixOutAttach(sda, I2C_SDA_IDX(i2c->num), false, false);`
`45`	`45`	`pinMatrixInAttach(sda, I2C_SDA_IDX(i2c->num), false);`
`46`	`46`	`}`