Skip to content
This repository was archived by the owner on May 16, 2023. It is now read-only.

Fixed setPrintMode()/unsetPrintMode() bugs. #4

Merged
merged 1 commit into from
Jul 30, 2013
Merged

Fixed setPrintMode()/unsetPrintMode() bugs. #4

merged 1 commit into from
Jul 30, 2013

Conversation

@masatomukoda
Copy link
Contributor

@masatomukoda masatomukoda commented Jul 29, 2013

Hi,

I had a feeling of strangeness:

  • Assign values to charHeight are switched.
  • And, assignment to charHeight and maxColumn should be performed in unsetPrintMode method.

Am I correct?

Thanks.

PaintYourDragon added a commit that referenced this pull request Jul 30, 2013
@PaintYourDragon
Merge pull request #4 from masatomukoda/mode
3b4dc2a 
Fixed setPrintMode()/unsetPrintMode() bugs.
@PaintYourDragon PaintYourDragon merged commit 3b4dc2a into adafruit:master Jul 30, 2013
@PaintYourDragon
Copy link
Contributor

PaintYourDragon commented Jul 30, 2013

Good eye. Thanks! I'll put this fix into the Arduino code as well, same bug lives there.

@masatomukoda masatomukoda deleted the mode branch September 13, 2013 03:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@masatomukoda @PaintYourDragon