Skip to content

NonblockingGenericDecode doesn't clear its buffer properly #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kry-Vosa opened this issue Oct 29, 2023 · 0 comments · Fixed by #67
Closed

NonblockingGenericDecode doesn't clear its buffer properly #66

Kry-Vosa opened this issue Oct 29, 2023 · 0 comments · Fixed by #67

Comments

@Kry-Vosa
Copy link
Contributor

If there are multiple messages in PulseIn, on the first pass through the loop the first message is decoded correctly, but the _unparsed_pulses buffer is not cleared, resulting in decode failures for any more messages in PulseIn

This issue rarely comes up, since usually one read()s so often that PulseIn doesn't contain pulses for more than one message, but e.g. in REPL it behaves completely incorrectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant