basic refactoring to remove errors #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
So this is now tested and ready to merge. It fixes a number of things (syntax wise and logic-wise), cleans the code and makes the API consistent with the INA219 library. |
BlitzCityDIY
approved these changes
May 5, 2025
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 13, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1107 to 2.0.2 from 2.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1107#28 from RetiredWizard/main Updating https://github.com/adafruit/Adafruit_CircuitPython_INA3221 to 1.1.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_INA3221#1 from bablokb/refactor Updating https://github.com/adafruit/Adafruit_CircuitPython_OV5640 to 1.2.5 from 1.2.4: > Merge pull request adafruit/Adafruit_CircuitPython_OV5640#36 from casten/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_RA8875 to 3.1.23 from 3.1.22: > Merge pull request adafruit/Adafruit_CircuitPython_RA8875#33 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_TLV320 to 1.1.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_TLV320#7 from adafruit/add_reset > Merge pull request adafruit/Adafruit_CircuitPython_TLV320#6 from adafruit/volume_update Updating https://github.com/adafruit/Adafruit_CircuitPython_Pathlib to 1.0.2 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_Pathlib#1 from FoamyGuy/fix_error_num
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently a draft PR: I refactored large parts of the code to make it at least error free from the Python perspective. I still have to setup the device and actually test it, but the current code definitely does not run (just run pylint, see all the errors and you know why).
Main changes: I moved a lot of the code from the container class
INA3221to theINA3221Channelclass. This not only simplifies logic and removes errors, but also follows usual OO design best practices (e.g. keep properties and related code where they belong).More to come (probably next year)...