-
Notifications
You must be signed in to change notification settings - Fork 2
Closed
Description
In this line:
| raise RuntimeError(self._PDO_RESPONSE_CODES[self.response]) |
The self.response value is being used to access the _PDO_RESPONSE_CODES list.
However at list index 2 is the value "INVALID COMMAND OR ARGUMENT" when this should be at list index 3.
This is because in the datasheet: https://en.hynetek.com/uploadfiles/site/219/news/eb6cc420-847e-40ec-a352-a86fbeedd331.pdf
The value 010 is not used in the PD_RESPONSE section of the PD_STATUS1 register.
The fix is to add another None value in the list.
So the following code:
Adafruit_CircuitPython_HUSB238/adafruit_husb238.py
Lines 141 to 147 in 94aab9b
| _PDO_RESPONSE_CODES = [ | |
| "NO RESPONSE", | |
| None, # Success | |
| "INVALID COMMAND OR ARGUMENT", | |
| "COMMAND NOT SUPPORTED", | |
| "TRANSACTION FAILED, NO GOOD CRC", | |
| ] |
Should instead be:
# PDO response codes
_PDO_RESPONSE_CODES = [
"NO RESPONSE",
None, # Success
None, # Reserved
"INVALID COMMAND OR ARGUMENT",
"COMMAND NOT SUPPORTED",
"TRANSACTION FAILED, NO GOOD CRC",
]Metadata
Metadata
Assignees
Labels
No labels