Add booleans for checking if user sets cert/key pair #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryneedell
approved these changes
Oct 10, 2019
Contributor
jerryneedell
left a comment
jerryneedell
left a comment
There was a problem hiding this comment.
I can't test this at this time, but the changes look good to me.
Contributor
|
Just a thought -- Is there ever a situation where you would want to clear this setting? |
Member
Author
|
@jerryneedell Possibly if |
Contributor
|
ah, but the user can just do that. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 10, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.0.1 from 3.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#78 from brentru/add-cert-psk-bools Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel to 3.4.0 from 3.3.7: > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#53 from caternuson/spi_neopixel Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.4.2 from 3.4.0: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#35 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#34 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_FancyLED to 1.3.2 from 1.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_FancyLED#14 from devoh747/devoh747
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of exposing
setCert/setPSKin nina-fw as commands, I'm adding two booleans toesp32spi.pyinstead,set_psk/set_crt.This is for checking if a user has set a certificate and/or psk prior to establishing a connection with a server.