From e093f2a2eb10ade43f9274dc88b3f36c9ebbdc7c Mon Sep 17 00:00:00 2001 From: ritesh006 Date: Wed, 27 Aug 2025 11:24:22 +0530 Subject: [PATCH] fix: raise ValueError instead of TypeError in issuer_or_subject_length (#30) Corrected the check when all issuer/subject fields are empty. Previously raised TypeError (misleading), now raises ValueError. Fixes #30. --- adafruit_atecc/adafruit_atecc_asn1.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/adafruit_atecc/adafruit_atecc_asn1.py b/adafruit_atecc/adafruit_atecc_asn1.py index 14b584c..d713c0e 100755 --- a/adafruit_atecc/adafruit_atecc_asn1.py +++ b/adafruit_atecc/adafruit_atecc_asn1.py @@ -268,6 +268,6 @@ def issuer_or_subject_length( tot_len += 11 + len(org_unit) if common: tot_len += 11 + len(common) - else: - raise TypeError("Provided length must be > 0") + if tot_len == 0: + raise TypeError("issuer_or_subject_length cannot be zero") return tot_len