fix: Allow to stop or remove workspaces using rich and old parameters (coder#6099)

mtojek · web-flow · commit fe725f76bb38 · 2023-02-08T14:09:52.000-06:00
* fix: Allow to stop or remove workspaces using rich and old parameters

* Fix
diff --git a/coderd/workspacebuilds.go b/coderd/workspacebuilds.go
@@ -518,7 +518,8 @@ func (api *API) postWorkspaceBuilds(rw http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	if len(legacyParameters) > 0 && len(parameters) > 0 {
+	if createBuild.Transition == codersdk.WorkspaceTransitionStart &&
+		len(legacyParameters) > 0 && len(parameters) > 0 {
 		httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{
 			Message: "Rich parameters can't be used together with legacy parameters.",
 		})

Original file line number	Diff line number	Diff line change
`@@ -518,7 +518,8 @@ func (api API) postWorkspaceBuilds(rw http.ResponseWriter, r http.Request) {`
`518`	`518`	`return`
`519`	`519`	`}`
`520`	`520`
`521`		`- if len(legacyParameters) > 0 && len(parameters) > 0 {`
	`521`	`+ if createBuild.Transition == codersdk.WorkspaceTransitionStart &&`
	`522`	`+ len(legacyParameters) > 0 && len(parameters) > 0 {`
`522`	`523`	`httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{`
`523`	`524`	`Message: "Rich parameters can't be used together with legacy parameters.",`
`524`	`525`	`})`