Skip to content

Commit e2b22ce

Browse files
committed
Drop support for Ruby 1.8.7
The time has finally come. While Ruby 1.8.7 technically EOLed a while ago, we were continuing to support it so users running older versions of OS X operating systems (and many Linux distributions) would be able to install it without doing anything. This was a pain, but not too much hassle. However, a dependency for our build infrastructure, RuboCop, depends on a gem that does not support Ruby 1.8.7. It's not worth it for us to jump through hoops to continue to support 1.8.7, so let's call it a good run and end it now. At some point we'll follow up with converting all the 1.8 hashes to 1.9 syntax, and removing any other 1.8.7 hacks. Change-Id: I9a048062bd905c685b8e5a633ca44af7cd1a7879 Reviewed-on: http://gerrit.causes.com/40470 Tested-by: jenkins <jenkins@causes.com> Reviewed-by: Shane da Silva <shane.dasilva@brigade.com>
1 parent d485751 commit e2b22ce

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
* Fix performance regression where running Overcommit in a repository
1010
with a lot of files would be very slow
1111
* Wildcards in include/exclude globs now match files beginning with `.`
12+
* Drop support for Ruby 1.8.7
1213

1314
## 0.13.0
1415

README.md

-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ about Overcommit on our [engineering blog](http://causes.github.io).
3232

3333
The following Ruby versions are supported:
3434

35-
* 1.8.7
3635
* 1.9.3
3736
* 2.0.0
3837
* 2.1.x

overcommit.gemspec

+1-2
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,9 @@ Gem::Specification.new do |s|
2424
Dir['libexec/**/*'] +
2525
Dir['template-dir/**/*']
2626

27-
s.required_ruby_version = '>= 1.8.7'
27+
s.required_ruby_version = '>= 1.9.3'
2828

2929
s.add_dependency 'childprocess', '>= 0.5.1'
30-
s.add_dependency 'json', '>= 1.8' # For 1.8.7. support only
3130

3231
s.add_development_dependency 'image_optim', '~> 0.13.0'
3332
s.add_development_dependency 'rspec', '~> 3.0'

0 commit comments

Comments
 (0)