Skip to content

Commit b5aacaa

Browse files
committedAug 1, 2014
Remove BundleCheck post-checkout hook
This hook presents a problem in a few edge cases where rebasing with could cause unfortunate merge conflicts to occur. Running this as a post-checkout hook is probably a bit overzealous. Remove it since the pre-commit hook should provide plenty of protection. Change-Id: I4be1572474a177c5cdfa859d512a0a4f786e5716 Reviewed-on: http://gerrit.causes.com/41206 Tested-by: jenkins <jenkins@causes.com> Reviewed-by: Shane da Silva <shane.dasilva@brigade.com>
1 parent 444231d commit b5aacaa

File tree

4 files changed

+1
-88
lines changed

4 files changed

+1
-88
lines changed
 

‎CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
applied, the hook runner would silently fail
1313
* Prevent stack traces from appearing during early interrupt before Overcommit
1414
has loaded its code
15+
* Remove `BundleCheck` post-checkout hook as it was a bit overzealous
1516

1617
## 0.15.0
1718

‎config/default.yml

-6
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,6 @@ PostCheckout:
2121
ALL:
2222
required: false
2323
quiet: false
24-
BundleCheck:
25-
description: 'Checking Gemfile dependencies'
26-
include:
27-
- 'Gemfile'
28-
- 'Gemfile.lock'
29-
- '*.gemspec'
3024
IndexTags:
3125
description: 'Generating tags file from source'
3226
enabled: false

‎lib/overcommit/hook/post_checkout/bundle_check.rb

-33
This file was deleted.

‎spec/overcommit/hook/post_checkout/bundle_check_spec.rb

-49
This file was deleted.

0 commit comments

Comments
 (0)
Please sign in to comment.