Begin adding specs for pre-commit hooks

Change-Id: I6ff20a406ae961b952ce91ca5bf6faed61e3b549
Reviewed-on: http://gerrit.causes.com/35563
Reviewed-by: Shane da Silva <shane@causes.com>
Tested-by: Shane da Silva <shane@causes.com>

Author: sds

TODO

@@ -18,6 +18,8 @@ Allow SKIP arguments to be case insensitive
 Move ReleaseNote check into Causes repo
 Enable hook by simply including it in repo-specific .overcommit.yml (no need
 to specify enabled: true)
+Display when a hook has been explicitly skipped when it would otherwise run
+Display when no applicable hooks ran (e.g. instead of "All pre-commit checks passed")
 
 
 Allow features of hooks to be customized (stealth, required, etc.)

lib/overcommit/configuration.rb

@@ -13,8 +13,8 @@ def plugin_directory
       File.join(Overcommit::Utils.repo_root, @hash['plugin_directory'])
     end
 
-    # Returns the hooks that have been enabled for a hook type.
-    def enabled_hooks(hook_type)
+    # Returns the built-in hooks that have been enabled for a hook type.
+    def enabled_builtin_hooks(hook_type)
       @hash[hook_type].keys.
         select { |hook_name| hook_name != 'ALL' }.
         select { |hook_name| @hash[hook_type][hook_name]['enabled'] != false }

lib/overcommit/configuration_loader.rb

@@ -16,6 +16,10 @@ def self.load_repo_config
       end
     end
 
+    def self.default_configuration
+      @default_config ||= load_from_file(DEFAULT_CONFIG_PATH)
+    end
+
   private
 
     # Loads a configuration, ensuring it extends the default configuration.
@@ -39,9 +43,5 @@ def self.load_from_file(file)
 
       Overcommit::Configuration.new(hash)
     end
-
-    def self.default_configuration
-      @default_config ||= load_from_file(DEFAULT_CONFIG_PATH)
-    end
   end
 end

lib/overcommit/hook/post_checkout/base.rb

@@ -5,7 +5,7 @@ module Overcommit::Hook::PostCheckout
   class Base < Overcommit::Hook::Base
     extend Forwardable
 
-    def_delegator :@context,
-                  *%i[previous_head new_head branch_checkout? file_checkout?]
+    def_delegators :@context,
+                   :previous_head, :new_head, :branch_checkout?, :file_checkout?
   end
 end

lib/overcommit/hook/pre_commit/coffee_lint.rb

@@ -7,8 +7,8 @@ def run
       end
 
       result = command("coffeelint --quiet #{applicable_files.join(' ')}")
-
-      return (result.success? ? :good : :bad), result.stdout
+      return :good if result.success?
+      return :bad, result.stdout
     end
   end
 end

lib/overcommit/hook/pre_commit/css_lint.rb

@@ -1,14 +1,14 @@
 module Overcommit::Hook::PreCommit
   # Runs `csslint` against any modified CSS files.
   class CssLint < Base
-    CSS_LINT = Overcommit::Utils.script_path('csslint-rhino.js')
-
     def run
-      return :warn, 'Rhino is not installed' unless in_path?('rhino')
+      unless in_path?('csslint')
+        return :warn, 'csslint not installed -- run `npm install -g csslint`'
+      end
 
       paths = applicable_files.join(' ')
 
-      result = command("rhino #{CSS_LINT} --quiet --format=compact #{paths} | grep 'Error - '")
+      result = command("csslint --quiet --format=compact #{paths} | grep 'Error - '")
       output = result.stdout
       return (output !~ /Error - (?!Unknown @ rule)/ ? :good : :bad), output
     end

lib/overcommit/hook/pre_commit/js_hint.rb

@@ -2,27 +2,14 @@ module Overcommit::Hook::PreCommit
   # Runs `jshint` against any modified JavaScript files.
   class JsHint < Base
     def run
-      return :warn, 'Need either `jshint` or `rhino` in path' unless runner
+      unless in_path?('jshint')
+        return :warn, 'jshint not installed -- run `npm install -g jshint`'
+      end
 
-      result = runner.call(applicable_files.join(' '))
+      result = command("jshint #{applicable_files.join(' ')}")
       output = result.stdout
 
       return (output.empty? ? :good : :bad), output
     end
-
-  private
-
-    JS_HINT_PATH        = Overcommit::Utils.script_path 'jshint.js'
-    JS_HINT_RUNNER_PATH = Overcommit::Utils.script_path 'jshint_runner.js'
-
-    def runner
-      if in_path?('jshint')
-        lambda { |paths| command("jshint #{paths}") }
-      elsif in_path?('rhino')
-        lambda do |paths|
-          command("rhino -strict -f #{JS_HINT_PATH} #{JS_HINT_RUNNER_PATH} #{paths} 2>&1 | grep -v warning | grep -v -e '^js: '")
-        end
-      end
-    end
   end
 end

lib/overcommit/hook/pre_commit/python_flake8.rb

@@ -2,7 +2,9 @@ module Overcommit::Hook::PreCommit
   # Runs `flake8` against any modified Python files.
   class PythonFlake8 < Base
     def run
-      return :warn, 'Run `pip install flake8`' unless in_path?('flake8')
+      unless in_path?('flake8')
+        return :warn, 'flake8 not installed -- run `pip install flake8`'
+      end
 
       result = command("flake8 #{applicable_files.join(' ')}")
 

lib/overcommit/hook/pre_commit/whitespace.rb

@@ -1,5 +1,5 @@
 module Overcommit::Hook::PreCommit
-  # Checks for invalid whitespace (hard tabs or trailig whitespace) in files.
+  # Checks for invalid whitespace (hard tabs or trailing whitespace) in files.
   class Whitespace < Base
     def run
       paths = applicable_files.join(' ')

lib/overcommit/hook_runner.rb

@@ -54,7 +54,7 @@ def load_hooks
     # Load hooks that ship with Overcommit, ignoring ones that are excluded from
     # the repository's configuration.
     def load_builtin_hooks
-      @config.enabled_hooks(underscored_hook_type).each do |hook_name|
+      @config.enabled_builtin_hooks(underscored_hook_type).each do |hook_name|
         underscored_hook_name = Overcommit::Utils.underscorize(hook_name)
         require "overcommit/hook/#{underscored_hook_type}/#{underscored_hook_name}"
         @hooks << create_hook(hook_name)