Update rspec 2.13.0 -> 2.14.1

After updating rspec, I noticed some deprecation warnings about `stub`,
instructing me to use `double` instead. So, I made that change at this
time to help things be ready for the future.

At the same time, I converted some double quotes to singles for code
consistency, and aligned some `let` blocks on the curlies for
readability.

Change-Id: I9d0f1c82779962be44012cbcb020b79468108824
Reviewed-on: https://gerrit.causes.com/33806
Tested-by: jenkins <jenkins@causes.com>
Reviewed-by: Shane da Silva <shane@causes.com>

Author: lencioni

overcommit.gemspec

@@ -21,6 +21,6 @@ Gem::Specification.new do |s|
             Dir['bin/**/*'] +
             Dir['config/*.yml']
 
-  s.add_development_dependency 'rspec', '2.13.0'
+  s.add_development_dependency 'rspec', '2.14.1'
   s.add_development_dependency 'image_optim', '0.9.1'
 end

spec/plugins/pre_commit/image_optimization/image_set_spec.rb

@@ -4,16 +4,16 @@
   describe '#initialize(image_paths)' do
     let(:path) { '/tmp/filename.jpg20131024-7103-s1d6n9.jpg' }
 
-    it "sets the image_paths of the image set" do
+    it 'sets the image_paths of the image set' do
       image_set = described_class.new([path])
       expect(image_set.image_paths).to eq([path])
     end
   end
 
   describe '#optimize_with(ImageOptim)' do
-    let(:optimized_image) { '/tmp/optimized.jpg' }
+    let(:optimized_image)   { '/tmp/optimized.jpg' }
     let(:unoptimized_image) { '/tmp/unoptimized.jpg' }
-    let(:image_optim) { stub('ImageOptim') }
+    let(:image_optim)       { double('ImageOptim') }
 
     it 'excludes already optimized images from the results' do
       image_optim.should_receive(:optimize_images!).

spec/plugins/pre_commit/image_optimization_spec.rb

@@ -3,14 +3,14 @@
 
 describe Overcommit::GitHook::ImageOptimization do
   describe '.filetypes' do
-    it "includes only image filetypes" do
+    it 'includes only image filetypes' do
       expect(described_class.filetypes).to eq([:gif, :jpeg, :jpg, :png])
     end
   end
 
   describe '#run_check' do
-    let(:image_optim) { stub(ImageOptim) }
-    let(:image_set) { stub(described_class::ImageSet) }
+    let(:image_optim)     { double(ImageOptim) }
+    let(:image_set)       { double(described_class::ImageSet) }
     let(:staged_filename) { 'filename.jpg' }
 
     around do |example|

spec/plugins/pre_commit/ruby_style_spec.rb

@@ -12,9 +12,9 @@
   end
 
   describe '#rubocop_yml_for' do
-    let(:staged_file) { stub(:original_path => 'some/dir') }
-    let(:existing) { stub(:file? => true) }
-    let(:non_existing) { stub(:file? => false) }
+    let(:staged_file)  { double(:original_path => 'some/dir') }
+    let(:existing)     { double(:file? => true) }
+    let(:non_existing) { double(:file? => false) }
 
     it 'returns the file that exists' do
       ruby_style.should_receive(:possible_files).
@@ -31,7 +31,7 @@
 
   describe '#rubocop_config_mapping' do
     it 'inserts the staged files into a hash' do
-      file = stub(:path => 'foobar/file.x')
+      file = double(:path => 'foobar/file.x')
       ruby_style.stub(:staged => [file])
       ruby_style.should_receive(:rubocop_yml_for).with(file).and_return('boing')
       ruby_style.send(:rubocop_config_mapping).should eq('boing' => ['foobar/file.x'])