Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: WebAssembly/wasm-c-api
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: WebAssembly/wasm-c-api
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: add_api_macro
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Oct 21, 2019

  1. Add WASI_API macro to each API entry point 

    This allows the build system do think such as:
  -DWASM_API=__attribute__((visibility("default")))

An alternative to this would be do something more explicit and
include the macros in the source like in binaryen:

 #if defined(_MSC_VER) && !defined(BUILD_STATIC_LIBRARY)
 efine BINARYEN_API __declspec(dllexport)
 #else

Or we could try to do it without tagging each entry point using:

 #pragma GCC visibility push
 #pragma GCC visibility pop

But these is less portable. For example I'm not sure if msvc supports
this kind of things.
    @sbc100
    sbc100 committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    9e8be06 View commit details
    Browse the repository at this point in the history
Loading