Skip to content

Commit 82f0cd6

Browse files
committed
Issue cocos2d#1267: update UIImageView.js
1 parent f4433a4 commit 82f0cd6

File tree

1 file changed

+19
-33
lines changed

1 file changed

+19
-33
lines changed

extensions/ccui/uiwidgets/UIImageView.js

Lines changed: 19 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ ccui.ImageView = ccui.Widget.extend(/** @lends ccui.ImageView# */{
7474
},
7575

7676
_initRenderer: function () {
77+
//todo create Scale9Sprite and setScale9Enabled(false)
7778
this._imageRenderer = new cc.Sprite();
7879
this.addProtectedChild(this._imageRenderer, ccui.ImageView.RENDERER_ZORDER, -1);
7980
},
@@ -88,6 +89,8 @@ ccui.ImageView = ccui.Widget.extend(/** @lends ccui.ImageView# */{
8889
* @param {ccui.Widget.LOCAL_TEXTURE|ccui.Widget.PLIST_TEXTURE} texType
8990
*/
9091
loadTexture: function (fileName, texType) {
92+
//todo use this code when _initRenderer use Scale9Sprite
93+
//if (!fileName || (this._textureFile == fileName && this._imageTexType == texType)) {
9194
if (!fileName) {
9295
return;
9396
}
@@ -97,6 +100,21 @@ ccui.ImageView = ccui.Widget.extend(/** @lends ccui.ImageView# */{
97100
this._imageTexType = texType;
98101
var imageRenderer = self._imageRenderer;
99102

103+
if(!imageRenderer.texture || !imageRenderer.texture.isLoaded()){
104+
imageRenderer.addEventListener("load", function(){
105+
self._findLayout();
106+
107+
self._imageTextureSize = imageRenderer.getContentSize();
108+
109+
self._updateChildrenDisplayedRGBA();
110+
111+
self._updateContentSizeWithTextureSize(self._imageTextureSize);
112+
if(self._scale9Enabled)
113+
self.setCapInsets(self._capInsets);
114+
self._imageRendererAdaptDirty = true;
115+
});
116+
}
117+
100118
switch (self._imageTexType) {
101119
case ccui.Widget.LOCAL_TEXTURE:
102120
if(self._scale9Enabled){
@@ -120,26 +138,7 @@ ccui.ImageView = ccui.Widget.extend(/** @lends ccui.ImageView# */{
120138
break;
121139
}
122140

123-
if(!imageRenderer.texture || !imageRenderer.texture.isLoaded()){
124-
imageRenderer.addEventListener("load", function(){
125-
self._findLayout();
126-
127-
self._imageTextureSize = imageRenderer.getContentSize();
128-
self._updateFlippedX();
129-
self._updateFlippedY();
130-
131-
self._updateChildrenDisplayedRGBA();
132-
133-
self._updateContentSizeWithTextureSize(self._imageTextureSize);
134-
if(self._scale9Enabled)
135-
self.setCapInsets(self._capInsets);
136-
self._imageRendererAdaptDirty = true;
137-
});
138-
}
139-
140141
self._imageTextureSize = imageRenderer.getContentSize();
141-
self._updateFlippedX();
142-
self._updateFlippedY();
143142

144143
this._updateChildrenDisplayedRGBA();
145144

@@ -156,25 +155,12 @@ ccui.ImageView = ccui.Widget.extend(/** @lends ccui.ImageView# */{
156155
this._imageRenderer.setTextureRect(rect);
157156
},
158157

159-
_updateFlippedX: function () {
160-
if (this._scale9Enabled)
161-
this._imageRenderer.setScaleX(this._flippedX ? -1 : 1);
162-
else
163-
this._imageRenderer.setFlippedX(this._flippedX);
164-
},
165-
166-
_updateFlippedY: function () {
167-
if (this._scale9Enabled)
168-
this._imageRenderer.setScaleY(this._flippedY ? -1 : 1);
169-
else
170-
this._imageRenderer.setFlippedY(this._flippedY);
171-
},
172-
173158
/**
174159
* Sets if button is using scale9 renderer.
175160
* @param {Boolean} able
176161
*/
177162
setScale9Enabled: function (able) {
163+
//todo setScale9Enabled
178164
if (this._scale9Enabled == able)
179165
return;
180166

0 commit comments

Comments
 (0)