Improve bare-property detection

bhollis · bhollis · commit aaaf1e17e0c5 · 2024-06-15T18:05:32.000-07:00
diff --git a/src/jsonformatter.ts b/src/jsonformatter.ts
@@ -58,10 +58,12 @@ function jsString(s: string): string {
 }
 
 /**
- * Is this a valid "bare" property name?
+ * Is this a valid "bare" property name (e.g. a JS identifier name or a numeric
+ * literal)? See https://mathiasbynens.be/notes/javascript-properties, though we
+ * only support a subset of valid identifier names (no weird Unicode stuff).
  */
 function isBareProp(prop: string): boolean {
-  return /^[A-Za-z_$][A-Za-z0-9_\-$]*$/.test(prop);
+  return /^([0-9]+|[A-Za-z_$][A-Za-z0-9_$]*)$/.test(prop);
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -58,10 +58,12 @@ function jsString(s: string): string {`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`/**`
`61`		`- * Is this a valid "bare" property name?`
	`61`	`+ * Is this a valid "bare" property name (e.g. a JS identifier name or a numeric`
	`62`	`+ * literal)? See https://mathiasbynens.be/notes/javascript-properties, though we`
	`63`	`+ * only support a subset of valid identifier names (no weird Unicode stuff).`
`62`	`64`	`*/`
`63`	`65`	`function isBareProp(prop: string): boolean {`
`64`		`- return /^[A-Za-z_$][A-Za-z0-9_\-$]*$/.test(prop);`
	`66`	`+ return /^([0-9]+\|[A-Za-z_$][A-Za-z0-9_$]*)$/.test(prop);`
`65`	`67`	`}`
`66`	`68`
`67`	`69`	`/**`