feat(tooltip) no longer depend upon 'tooltips.less' as it might not be present in some theme

Author: basarat

dist/main/atom/tooltipManager.js

@@ -36,7 +36,7 @@ function attach(editorView, editor) {
         var pixelPt = pixelPositionFromMouseEvent(editorView, e);
         var screenPt = editor.screenPositionForPixelPosition(pixelPt);
         var bufferPt = editor.bufferPositionForScreenPosition(screenPt);
-        if (lastExprTypeBufferPt && lastExprTypeBufferPt.isEqual(bufferPt))
+        if (lastExprTypeBufferPt && lastExprTypeBufferPt.isEqual(bufferPt) && exprTypeTooltip)
             return;
         lastExprTypeBufferPt = bufferPt;
         clearExprTypeTimeout();

dist/main/atom/views/tooltipView.js

@@ -15,11 +15,15 @@ var TooltipView = (function (_super) {
         this.updatePosition();
     }
     TooltipView.content = function () {
-        return this.div({ class: 'atom-typescript-tooltip' });
+        var _this = this;
+        return this.div({ class: 'atom-typescript-tooltip tooltip' }, function () {
+            _this.div({ class: 'tooltip-inner', outlet: 'inner' });
+        });
     };
     TooltipView.prototype.updateText = function (text) {
-        this.$.html(text);
+        this.inner.html(text);
         this.updatePosition();
+        this.$.fadeTo(300, 1);
     };
     TooltipView.prototype.updatePosition = function () {
         var offset = 10;

lib/main/atom/tooltipManager.ts

@@ -43,15 +43,15 @@ export function attach(editorView: JQuery, editor: AtomCore.IEditor) {
     var subscriber = new Subscriber();
     var exprTypeTimeout = null;
     var exprTypeTooltip: TooltipView = null;
-    
+
     // to debounce mousemove event's firing for some reason on some machines
     var lastExprTypeBufferPt: any;
 
     subscriber.subscribe(scroll, 'mousemove', (e) => {
         var pixelPt = pixelPositionFromMouseEvent(editorView, e)
         var screenPt = editor.screenPositionForPixelPosition(pixelPt)
         var bufferPt = editor.bufferPositionForScreenPosition(screenPt)
-        if (lastExprTypeBufferPt && lastExprTypeBufferPt.isEqual(bufferPt))
+        if (lastExprTypeBufferPt && lastExprTypeBufferPt.isEqual(bufferPt) && exprTypeTooltip)
             return;
 
         lastExprTypeBufferPt = bufferPt;

lib/main/atom/views/tooltipView.ts

@@ -10,19 +10,23 @@ interface Rect {
 
 export class TooltipView extends view.View<any> {
 
-    constructor(public rect:Rect) {
+    constructor(public rect: Rect) {
         super();
         $(document.body).append(this.$);
         this.updatePosition()
     }
 
+    private inner: JQuery;
     static content() {
-        return this.div({ class: 'atom-typescript-tooltip' });
+        return this.div({ class: 'atom-typescript-tooltip tooltip' }, () => {
+            this.div({ class: 'tooltip-inner', outlet: 'inner' })
+        });
     }
 
     updateText(text: string) {
-        this.$.html(text);
+        this.inner.html(text);
         this.updatePosition();
+        this.$.fadeTo(300, 1);
     }
 
     updatePosition() {

styles/atom-typescript-tooltip.less

@@ -0,0 +1,12 @@
+// Most of the styles for this get inherited from the .tooltip class that we apply to the same element in the DOM
+.atom-typescript-tooltip {
+    font-family: Consolas, monospace;
+    white-space: pre !important;
+
+    border-radius: 5px;
+
+    // This class exists by default and this is what we are using
+    .tooltip-inner{
+        text-align: left;
+    }
+}

styles/atom-typescript.less

@@ -8,11 +8,3 @@ declare class AtomView {
     // Methods from base View
     remove();
 }
-
-declare module 'views/tooltip' {
-    class TooltipView extends AtomView {
-        constructor(rect: any);
-        updateText(text: string);
-    }
-	export = TooltipView;
-}