fixed regression: accept empty version in 'core install'

Author: cmaglie

cli/core/update_index.go

@@ -49,7 +49,7 @@ func runUpdateIndexCommand(cmd *cobra.Command, args []string) {
 		Instance: instance,
 	}, cli.OutputProgressBar())
 	if err != nil {
-		formatter.PrintError(err, "Error during install")
+		formatter.PrintError(err, "Error updating index")
 		os.Exit(cli.ErrGeneric)
 	}
 }

commands/core/download.go

@@ -36,10 +36,12 @@ func PlatformDownload(ctx context.Context, req *rpc.PlatformDownloadReq, downloa
 	}
 
 	var version *semver.Version
-	if v, err := semver.Parse(req.Version); err == nil {
-		version = v
-	} else {
-		return nil, fmt.Errorf("invalid version: %s", err)
+	if req.GetVersion() != "" {
+		if v, err := semver.Parse(req.GetVersion()); err == nil {
+			version = v
+		} else {
+			return nil, fmt.Errorf("invalid version: %s", err)
+		}
 	}
 
 	platform, tools, err := pm.FindPlatformReleaseDependencies(&packagemanager.PlatformReference{

commands/core/install.go

@@ -38,8 +38,8 @@ func PlatformInstall(ctx context.Context, req *rpc.PlatformInstallReq,
 	}
 
 	var version *semver.Version
-	if req.Version != "" {
-		if v, err := semver.Parse(req.Version); err == nil {
+	if req.GetVersion() != "" {
+		if v, err := semver.Parse(req.GetVersion()); err == nil {
 			version = v
 		} else {
 			return nil, fmt.Errorf("invalid version: %s", err)

commands/instances.go

@@ -132,7 +132,7 @@ func UpdateLibrariesIndex(ctx context.Context, lm *librariesmanager.LibrariesMan
 	if err != nil {
 		return err
 	}
-	Download(d, "library_index.json", downloadCB)
+	Download(d, "Updating index: library_index.json", downloadCB)
 	if d.Error() != nil {
 		return d.Error()
 	}