Skip to content

Commit f7caf78

Browse files
committed
remove empty
1 parent dfdea30 commit f7caf78

24 files changed

+91
-99
lines changed

jscomp/others/belt_MapDict.ml

+7-7
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ type ('key, 'a, 'id) t = ('key, 'a) N.t
2929

3030
type ('key, 'id) cmp = ('key, 'id) Belt_Id.cmp
3131

32-
let empty = N.empty
32+
let empty = None
3333
let fromArray = N.fromArray
3434
let isEmpty = N.isEmpty
3535
let cmp = N.cmp
@@ -175,7 +175,7 @@ let rec removeAux0 n x ~cmp =
175175

176176
let remove n x ~cmp =
177177
match n with
178-
| None -> N.empty
178+
| None -> None
179179
| Some n -> removeAux0 n x ~cmp
180180

181181
let mergeMany h arr ~cmp =
@@ -198,14 +198,14 @@ let rec splitAuxPivot n x pres ~cmp =
198198
if c < 0 then
199199
match l with
200200
| None ->
201-
N.empty, N.return n
201+
None, N.return n
202202
| Some l ->
203203
let (ll,rl) = splitAuxPivot ~cmp l x pres in
204204
(ll, N.join rl v d r)
205205
else
206206
match r with
207207
| None ->
208-
N.return n, N.empty
208+
N.return n, None
209209
| Some r ->
210210
let (lr, rr) = splitAuxPivot ~cmp r x pres in
211211
(N.join l v d lr, rr)
@@ -214,7 +214,7 @@ let rec splitAuxPivot n x pres ~cmp =
214214
let split n x ~cmp =
215215
match n with
216216
| None ->
217-
(N.empty, N.empty), None
217+
(None, None), None
218218
| Some n ->
219219
let pres = ref None in
220220
let v = splitAuxPivot ~cmp n x pres in
@@ -225,7 +225,7 @@ let findFirstBy = N.findFirstBy
225225

226226
let rec mergeU s1 s2 f ~cmp =
227227
match s1, s2 with
228-
(None, None) -> N.empty
228+
(None, None) -> None
229229
| Some _, None ->
230230
N.keepMapU s1 (fun[@bs] k v ->
231231
f k (Some v) None [@bs]
@@ -270,7 +270,7 @@ let rec removeMany0 t xs i len ~cmp =
270270
let removeMany t keys ~cmp =
271271
let len = A.length keys in
272272
match t with
273-
| None -> N.empty
273+
| None -> None
274274
| Some t -> removeMany0 t keys 0 len ~cmp
275275

276276

jscomp/others/belt_MapInt.ml

+3-3
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ module A = Belt_Array
88

99
type 'a t = (key, 'a) N.t
1010

11-
let empty = N.empty
11+
let empty = None
1212
let isEmpty = N.isEmpty
1313
(* let singleton = N.singleton *)
1414

@@ -121,7 +121,7 @@ let rec removeAux n (x : key) =
121121

122122
let remove n x =
123123
match n with
124-
| None -> N.empty
124+
| None -> None
125125
| Some n -> removeAux n x
126126

127127
let rec removeMany0 t xs i len =
@@ -137,7 +137,7 @@ let rec removeMany0 t xs i len =
137137
let removeMany t keys =
138138
let len = A.length keys in
139139
match t with
140-
| None -> N.empty
140+
| None -> None
141141
| Some t -> removeMany0 t keys 0 len
142142

143143
let findFirstByU = N.findFirstByU

jscomp/others/belt_MapString.ml

+3-3
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ module A = Belt_Array
88

99
type 'a t = (key, 'a) N.t
1010

11-
let empty = N.empty
11+
let empty = None
1212
let isEmpty = N.isEmpty
1313
(* let singleton = N.singleton *)
1414

@@ -121,7 +121,7 @@ let rec removeAux n (x : key) =
121121

122122
let remove n x =
123123
match n with
124-
| None -> N.empty
124+
| None -> None
125125
| Some n -> removeAux n x
126126

127127
let rec removeMany0 t xs i len =
@@ -137,7 +137,7 @@ let rec removeMany0 t xs i len =
137137
let removeMany t keys =
138138
let len = A.length keys in
139139
match t with
140-
| None -> N.empty
140+
| None -> None
141141
| Some t -> removeMany0 t keys 0 len
142142

143143
let findFirstByU = N.findFirstByU

jscomp/others/belt_MutableMap.ml

+3-3
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ let rec removeArrayMutateAux t xs i len ~cmp =
8484
let ele = A.getUnsafe xs i in
8585
let u = removeMutateAux t ele ~cmp in
8686
match u with
87-
| None -> N.empty
87+
| None -> None
8888
| Some t -> removeArrayMutateAux t xs (i+1) len ~cmp
8989
else N.return t
9090

@@ -141,9 +141,9 @@ let update t x f = updateU t x (fun [@bs] a -> f a)
141141

142142
let make (type key) (type identity) ~(id : (key,identity) id) =
143143
let module M = (val id) in
144-
{cmp = M.cmp ; data = N.empty}
144+
{cmp = M.cmp ; data = None}
145145

146-
let clear m = m.data <- N.empty
146+
let clear m = m.data <- None
147147

148148
let isEmpty d =
149149
N.isEmpty (d.data)

jscomp/others/belt_MutableMapInt.ml

+3-3
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ type 'a t = {
1313
}
1414

1515

16-
let make () = {data = N.empty}
16+
let make () = {data = None}
1717
let isEmpty m = N.isEmpty m.data
18-
let clear m = m.data<- N.empty
18+
let clear m = m.data<- None
1919
(* let singleton k v = t ~data:(N.singleton k v) *)
2020

2121
let minKeyUndefined m = N.minKeyUndefined m.data
@@ -135,7 +135,7 @@ let rec removeArrayMutateAux t xs i len =
135135
let ele = A.getUnsafe xs i in
136136
let u = removeMutateAux t ele in
137137
match u with
138-
| None -> N.empty
138+
| None -> None
139139
| Some t -> removeArrayMutateAux t xs (i+1) len
140140
else N.return t
141141

jscomp/others/belt_MutableMapString.ml

+3-3
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ type 'a t = {
1313
}
1414

1515

16-
let make () = {data = N.empty}
16+
let make () = {data = None}
1717
let isEmpty m = N.isEmpty m.data
18-
let clear m = m.data<- N.empty
18+
let clear m = m.data<- None
1919
(* let singleton k v = t ~data:(N.singleton k v) *)
2020

2121
let minKeyUndefined m = N.minKeyUndefined m.data
@@ -135,7 +135,7 @@ let rec removeArrayMutateAux t xs i len =
135135
let ele = A.getUnsafe xs i in
136136
let u = removeMutateAux t ele in
137137
match u with
138-
| None -> N.empty
138+
| None -> None
139139
| Some t -> removeArrayMutateAux t xs (i+1) len
140140
else N.return t
141141

jscomp/others/belt_internalAVLtree.ml

+12-12
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ module A = Belt_Array
2929
module S = Belt_SortArray
3030

3131
external return : 'a -> 'a option = "%identity"
32-
let empty = None
32+
3333
external unsafeCoerce : 'a option -> 'a = "%identity"
3434

3535

@@ -51,7 +51,7 @@ let create l x d r =
5151
return { left = l ; key = x ; value = d ; right = r ; height = (if hl >= hr then hl + 1 else hr + 1)}
5252

5353
let singleton x d =
54-
return { left = empty; key = x; value = d; right = empty; height = 1}
54+
return { left = None; key = x; value = d; right = None; height = 1}
5555

5656
let heightGe l r =
5757
match l, r with
@@ -198,7 +198,7 @@ let forEach n f = forEachU n (fun [@bs] a b -> f a b)
198198
let rec mapU n f =
199199
match n with
200200
None ->
201-
empty
201+
None
202202
| Some n ->
203203
let newLeft = n .left |. mapU f in
204204
let newD = f n.value [@bs] in
@@ -210,7 +210,7 @@ let map n f = mapU n (fun[@bs] a -> f a)
210210
let rec mapWithKeyU n f =
211211
match n with
212212
None ->
213-
empty
213+
None
214214
| Some n ->
215215
let key = n.key in
216216
let newLeft = n .left |. mapWithKeyU f in
@@ -304,7 +304,7 @@ let concatOrJoin t1 v d t2 =
304304

305305
let rec keepSharedU n p =
306306
match n with
307-
None -> empty
307+
None -> None
308308
| Some n ->
309309
(* call [p] in the expected left-to-right order *)
310310
let {key = v; value = d} = n in
@@ -317,7 +317,7 @@ let keepShared n p = keepSharedU n (fun [@bs] a b -> p a b)
317317

318318
let rec keepMapU n p =
319319
match n with
320-
None -> empty
320+
None -> None
321321
| Some n ->
322322
(* call [p] in the expected left-to-right order *)
323323
let {key = v; value = d} = n in
@@ -332,7 +332,7 @@ let keepMap n p = keepMapU n (fun[@bs] a b -> p a b)
332332

333333
let rec partitionSharedU n p =
334334
match n with
335-
None -> (empty, empty)
335+
None -> (None, None)
336336
| Some n ->
337337
let {key; value } = n in
338338
(* call [p] in the expected left-to-right order *)
@@ -499,12 +499,12 @@ let valuesToArray n =
499499

500500
let rec fromSortedArrayRevAux arr off len =
501501
match len with
502-
| 0 -> empty
502+
| 0 -> None
503503
| 1 -> let k, v = (A.getUnsafe arr off) in singleton k v
504504
| 2 ->
505505
let (x0,y0),(x1,y1) = A.(getUnsafe arr off, getUnsafe arr (off - 1) )
506506
in
507-
return { left = (singleton x0 y0); key = x1; value = y1; height = 2; right = empty}
507+
return { left = (singleton x0 y0); key = x1; value = y1; height = 2; right = None}
508508
| 3 ->
509509
let (x0,y0),(x1,y1),(x2,y2) =
510510
A.(getUnsafe arr off,
@@ -526,12 +526,12 @@ let rec fromSortedArrayRevAux arr off len =
526526

527527
let rec fromSortedArrayAux arr off len =
528528
match len with
529-
| 0 -> empty
529+
| 0 -> None
530530
| 1 -> let k, v = (A.getUnsafe arr off) in singleton k v
531531
| 2 ->
532532
let (x0,y0),(x1,y1) = A.(getUnsafe arr off, getUnsafe arr (off + 1) )
533533
in
534-
return {left = (singleton x0 y0); key = x1 ; value = y1; height = 2; right = empty}
534+
return {left = (singleton x0 y0); key = x1 ; value = y1; height = 2; right = None}
535535
| 3 ->
536536
let (x0,y0),(x1,y1),(x2,y2) =
537537
A.(getUnsafe arr off,
@@ -734,7 +734,7 @@ let rec updateMutate (t : _ t) x data ~cmp =
734734

735735
let fromArray (xs : _ array) ~cmp =
736736
let len = A.length xs in
737-
if len = 0 then empty
737+
if len = 0 then None
738738
else
739739
let next =
740740
ref (S.strictlySortedLengthU xs

jscomp/others/belt_internalAVLtree.mli

+1-2
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,7 @@ and ('k, 'v) node = {
3737

3838

3939
external return : 'a -> 'a option = "%identity"
40-
val empty : _ t
41-
(* val empty : _ t *)
40+
4241
type ('k, 'id) cmp = ('k, 'id) Belt_Id.cmp
4342

4443
val copy : ('k, 'v) t -> ('k, 'v) t

jscomp/others/belt_internalMapInt.ml

+5-5
Original file line numberDiff line numberDiff line change
@@ -90,27 +90,27 @@ let rec splitAux (x : key) (n : _ N.node) : _ t * _ option * _ t =
9090
if x < v then
9191
match l with
9292
| None ->
93-
N.(empty , None, return n)
93+
None, None, Some n
9494
| Some l ->
9595
let (ll, pres, rl) = splitAux x l in (ll, pres, N.join rl v d r)
9696
else
9797
match r with
9898
| None ->
99-
N.(return n, None, empty)
99+
Some n, None, None
100100
| Some r ->
101101
let (lr, pres, rr) = splitAux x r in (N.join l v d lr, pres, rr)
102102

103103

104104
let split (x : key) n =
105105
match n with
106106
None ->
107-
N.(empty, None, empty)
107+
None, None, None
108108
| Some n ->
109109
splitAux x n
110110

111111
let rec mergeU s1 s2 f =
112112
match s1, s2 with
113-
(None, None) -> N.empty
113+
(None, None) -> None
114114
| Some n (* (Node (l1, v1, d1, r1, h1), _)*), _
115115
when (n.N.height >= (match s2 with None -> 0 | Some n -> n.N.height)) ->
116116
let {N.left = l1; key = v1; value = d1; right = r1} = n in
@@ -197,7 +197,7 @@ let rec addMutate (t : _ t) x data : _ t =
197197

198198
let fromArray (xs : (key * _) array) =
199199
let len = A.length xs in
200-
if len = 0 then N.empty
200+
if len = 0 then None
201201
else
202202
let next =
203203
ref (S.strictlySortedLengthU xs

jscomp/others/belt_internalMapString.ml

+5-5
Original file line numberDiff line numberDiff line change
@@ -90,27 +90,27 @@ let rec splitAux (x : key) (n : _ N.node) : _ t * _ option * _ t =
9090
if x < v then
9191
match l with
9292
| None ->
93-
N.(empty , None, return n)
93+
None, None, Some n
9494
| Some l ->
9595
let (ll, pres, rl) = splitAux x l in (ll, pres, N.join rl v d r)
9696
else
9797
match r with
9898
| None ->
99-
N.(return n, None, empty)
99+
Some n, None, None
100100
| Some r ->
101101
let (lr, pres, rr) = splitAux x r in (N.join l v d lr, pres, rr)
102102

103103

104104
let split (x : key) n =
105105
match n with
106106
None ->
107-
N.(empty, None, empty)
107+
None, None, None
108108
| Some n ->
109109
splitAux x n
110110

111111
let rec mergeU s1 s2 f =
112112
match s1, s2 with
113-
(None, None) -> N.empty
113+
(None, None) -> None
114114
| Some n (* (Node (l1, v1, d1, r1, h1), _)*), _
115115
when (n.N.height >= (match s2 with None -> 0 | Some n -> n.N.height)) ->
116116
let {N.left = l1; key = v1; value = d1; right = r1} = n in
@@ -197,7 +197,7 @@ let rec addMutate (t : _ t) x data : _ t =
197197

198198
let fromArray (xs : (key * _) array) =
199199
let len = A.length xs in
200-
if len = 0 then N.empty
200+
if len = 0 then None
201201
else
202202
let next =
203203
ref (S.strictlySortedLengthU xs

0 commit comments

Comments
 (0)