remove %bswap_16 which is rarely used

Author: bobzhang

jscomp/core/lam_analysis.ml

@@ -84,7 +84,6 @@ let rec no_side_effects (lam : Lam.t) : bool =
         end
 
       | Pcreate_extension _
-      (* | Pcreate_exception _ *)
       | Pjs_typeof
       | Pis_null
       | Pis_not_none
@@ -162,7 +161,6 @@ let rec no_side_effects (lam : Lam.t) : bool =
       | Pstringadd 
       | Pjs_function_length
       | Pcaml_obj_length
-      (* | Pjs_is_instance_array *)
       | Pwrap_exn
       | Praw_js_code {code_info = Exp (Js_function _ | Js_literal _) | Stmt Js_stmt_comment}
         -> true
@@ -185,7 +183,6 @@ let rec no_side_effects (lam : Lam.t) : bool =
       (* Operations on boxed integers (Nativeint.t, Int32.t, Int64.t) *)
       | Parraysets 
       (* byte swap *)
-      | Pbswap16
       | Pbbswap _
       | Parraysetu  
       | Poffsetref _ 

jscomp/core/lam_compile_primitive.ml

@@ -616,9 +616,6 @@ let translate  loc
     -> 
     Lam_dispatch_primitive.translate loc "caml_obj_dup" args
     (* check dubug mode *)  
-  | Pbswap16 
-    -> 
-    E.runtime_call Js_runtime_modules.int32 "caml_bswap16" args
   | Pbbswap Lambda.Pnativeint
   | Pbbswap Lambda.Pint32
     -> 

jscomp/core/lam_convert.ml

@@ -353,8 +353,6 @@ let lam_prim ~primitive:( p : Lambda.primitive) ~args loc : Lam.t =
   | Psubfloat -> prim ~primitive:Psubfloat ~args loc
   | Pmulfloat -> prim ~primitive:Pmulfloat ~args loc
   | Pdivfloat -> prim ~primitive:Pdivfloat ~args loc
-
-  | Pbswap16 -> prim ~primitive:Pbswap16 ~args loc
   | Pintcomp x -> prim ~primitive:(Pintcomp x)  ~args loc
   | Poffsetint x -> prim ~primitive:(Poffsetint x) ~args loc
   | Poffsetref x -> prim ~primitive:(Poffsetref x) ~args  loc
@@ -427,6 +425,8 @@ let lam_prim ~primitive:( p : Lambda.primitive) ~args loc : Lam.t =
   | Popaque -> Ext_list.singleton_exn args      
   | Psetfield_computed _ ->  
     prim ~primitive:Psetfield_computed ~args loc 
+
+  | Pbswap16 
   | Pduparray _ ->  assert false 
     (* Does not exist since we compile array in js backend unlike native backend *)
 

jscomp/core/lam_primitive.ml

@@ -112,9 +112,7 @@ type t =
 
   (* Compile time constants *)
   | Pctconst of Lam_compat.compile_time_constant
-  (* byte swap *)
-  | Pbswap16
-  | Pbbswap of Lam_compat.boxed_integer
+  | Pbbswap of Lam_compat.boxed_integer 
   (* Integer to external pointer *)
 
   | Pdebugger
@@ -239,7 +237,6 @@ let eq_primitive_approx ( lhs : t) (rhs : t) =
   | Pdebugger -> rhs = Pdebugger    
   | Pinit_mod -> rhs = Pinit_mod
   | Pupdate_mod -> rhs = Pupdate_mod
-  | Pbswap16 -> rhs = Pbswap16
   | Pjs_function_length -> rhs = Pjs_function_length
   (* | Pjs_string_of_small_array -> rhs = Pjs_string_of_small_array *)
   (* | Pjs_is_instance_array -> rhs = Pjs_is_instance_array *)

jscomp/core/lam_primitive.mli

@@ -108,8 +108,6 @@ type t =
 
   (* Compile time constants *)
   | Pctconst of Lam_compat.compile_time_constant
-  (* byte swap *)
-  | Pbswap16
   | Pbbswap of Lam_compat.boxed_integer
   (* Integer to external pointer *)
 

jscomp/core/lam_print.ml

@@ -240,7 +240,6 @@ let primitive ppf (prim : Lam_primitive.t) = match prim with
   | Pbintcomp(bi, Cgt) -> print_boxed_integer ">" ppf bi
   | Pbintcomp(bi, Cle) -> print_boxed_integer "<=" ppf bi
   | Pbintcomp(bi, Cge) -> print_boxed_integer ">=" ppf bi
-  | Pbswap16 -> fprintf ppf "bswap16"
   | Pbbswap(bi) -> print_boxed_integer "bswap" ppf bi
 
 

jscomp/runtime/caml_int32.ml

@@ -38,10 +38,6 @@ let mod_ (x : nativeint) (y:nativeint) =
   else Caml_nativeint_extern.rem x  y
 
 
-let caml_bswap16 (x : nativeint) = 
- let open Caml_nativeint_extern in 
- logor (shift_left (logand x 0x00ffn) 8)
-    (shift_right_logical (logand x 0xff00n) 8)
 
 let caml_int32_bswap (x : nativeint) = 
   let open Caml_nativeint_extern in 

jscomp/runtime/caml_int32.mli

@@ -28,7 +28,6 @@ val div : nativeint -> nativeint -> nativeint
 
 val mod_ : nativeint -> nativeint -> nativeint
 
-val caml_bswap16 : nativeint -> nativeint
 
 val caml_int32_bswap : nativeint -> nativeint
 

jscomp/test/build.ninja

@@ -562,7 +562,7 @@ build test/string_unicode_test.cmi test/string_unicode_test.cmj : cc test/string
 build test/stringmatch_test.cmi test/stringmatch_test.cmj : cc test/stringmatch_test.ml | $stdlib
 build test/submodule.cmi test/submodule.cmj : cc test/submodule.ml | $stdlib
 build test/submodule_call.cmi test/submodule_call.cmj : cc test/submodule_call.ml | test/submodule.cmj $stdlib
-build test/swap_test.cmi test/swap_test.cmj : cc test/swap_test.ml | test/mt.cmj $stdlib
+build test/swap_test.cmi test/swap_test.cmj : cc test/swap_test.ml | $stdlib
 build test/switch_case_test.cmi test/switch_case_test.cmj : cc test/switch_case_test.ml | test/mt.cmj $stdlib
 build test/tailcall_inline_test.cmi test/tailcall_inline_test.cmj : cc test/tailcall_inline_test.ml | test/mt.cmj $stdlib
 build test/test.cmi test/test.cmj : cc test/test.ml | $stdlib